From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id OGazEuY+kmHCUQEAgWs5BA (envelope-from ) for ; Mon, 15 Nov 2021 12:05:10 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id mKJrDuY+kmFIBAAA1q6Kng (envelope-from ) for ; Mon, 15 Nov 2021 11:05:10 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id E59C1168BB for ; Mon, 15 Nov 2021 12:05:09 +0100 (CET) Received: from localhost ([::1]:39728 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mmZnR-0003Nb-3s for larch@yhetil.org; Mon, 15 Nov 2021 06:05:09 -0500 Received: from eggs.gnu.org ([209.51.188.92]:56016) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mmZnK-0003NF-M4 for guix-patches@gnu.org; Mon, 15 Nov 2021 06:05:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:41235) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mmZnK-0005kO-Da for guix-patches@gnu.org; Mon, 15 Nov 2021 06:05:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mmZnK-00081C-6S for guix-patches@gnu.org; Mon, 15 Nov 2021 06:05:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#51346] [PATCH 0/1 core-updates-frozen] Rework swap device to add dependencies and flags Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 15 Nov 2021 11:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51346 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Josselin Poiret Cc: Tobias Geerinckx-Rice , 51346@debbugs.gnu.org Received: via spool by 51346-submit@debbugs.gnu.org id=B51346.163697427330775 (code B ref 51346); Mon, 15 Nov 2021 11:05:02 +0000 Received: (at 51346) by debbugs.gnu.org; 15 Nov 2021 11:04:33 +0000 Received: from localhost ([127.0.0.1]:52781 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mmZmr-00080J-Fk for submit@debbugs.gnu.org; Mon, 15 Nov 2021 06:04:33 -0500 Received: from eggs.gnu.org ([209.51.188.92]:55188) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mmZmp-000806-DG for 51346@debbugs.gnu.org; Mon, 15 Nov 2021 06:04:31 -0500 Received: from [2001:470:142:3::e] (port=58022 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mmZmk-0005hh-6Q; Mon, 15 Nov 2021 06:04:26 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=cCimXRk9RYXQWlcsF6NOhb3bMXUbm7x42f5INIJYr0w=; b=frOpF+7aMEe+RgCyZ2vA r+gUv2rSflJOLhCdY+RSAkGWC4UVpePX/nnXHEXRjNUaEOHwbW9gJ861NfqYJbtRdFOYYZ9EeYiE5 jlcL8eHj9zVcqQk2clQ/7i1Wba1f2A4yIGGqsdKEyUbx4wTlzHMwwj+YDLRQEle/NkoO2btNkdKnv c3zOQfysP8KvSo+DNg+EpIm500sFWVXX4voXlWdakXrUX+RQGysB+7rDbgmNbo1I8UYaKTYULptmA J5gipKTCmHyTalJncLy2iG6k9w3aht0w6k0WmgNL0qdnEulcViCmugYXqyTYmUDhwdCJ594oM8my7 pBnntcUJ4XwGQA==; Received: from [193.50.110.110] (port=57556 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mmZmj-0001Ys-RY; Mon, 15 Nov 2021 06:04:26 -0500 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <87tuh6ifwe.fsf@nckx> <20211027150913.6038-1-dev@jpoiret.xyz> <20211027150913.6038-2-dev@jpoiret.xyz> Date: Mon, 15 Nov 2021 12:04:24 +0100 In-Reply-To: <20211027150913.6038-2-dev@jpoiret.xyz> (Josselin Poiret's message of "Wed, 27 Oct 2021 15:09:10 +0000") Message-ID: <87y25p65on.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1636974310; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=cCimXRk9RYXQWlcsF6NOhb3bMXUbm7x42f5INIJYr0w=; b=cPGLq+K4tpIcNHoLdh/qmp3Cvr4uhdRV3076YzFQETBgnbIlWMxXWidpC01MEb/3FaZS8u 22sJW2qIyXvtfbOSkpDxAz7k9XujsqrehCJ/Ma2bZYkEvFG8jSKHQRGNpN3zFR8x3AfYea k23EzDdaBJ4ZxQyPZm/QwYjkXYs8BKADLZFa2ZZKvn9jmNG9JFgsc00nLz5/vzYhJ5lkau gMZc/gDpHh8zhHH0hwMAuL/Wv6RMaOlL4uptqN8zoUfoQXvEhc6DBP2ZTeEeCgeYThQCvq 937Czpg09mNcmJyAWLxfVG0hZGs95AbxsvVvW941a4RVOUpFKg5Ru4U5bV85RA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1636974310; a=rsa-sha256; cv=none; b=GqduGMnEA1xkaMJFdVccqZXZSGBq/lQro+r4JUzQpNJAMFDqtS2QV0iosHOfEfH6OA+JoV HCB7vdNK4M3ZUHU9gKq9nqZUgv4N0eOp3RLAdxqs+PwPIVByIOzpNUMVPmR532jSGxvPyQ gY3wGeaJttdiMVtMgrzUdAl7W9Jv6690Wbz7XwAiJGybkyKV94fyDiegy25VVnGMU9uDUM mlV3bxU4BmGddVj5KyWqDgkS0icDNUw+ZWLSksLKvcS+9WfKTMQpKfEXrxuJm4UwxcYy58 5ai546r6hlZZQbSgaWn3OyLomJS/UDyqqWR1JwsbPYVI3v0ukDQ5I4MXDYrkvg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=frOpF+7a; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -3.54 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=frOpF+7a; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: E59C1168BB X-Spam-Score: -3.54 X-Migadu-Scanner: scn1.migadu.com X-TUID: 18nstJfd3fx0 Josselin Poiret skribis: > + (lambda (swap) > + (define requirements > + (cond ((swap-space? swap) > + (map dependency->shepherd-service-name > + (swap-space-dependencies swap))) > + ; TODO Remove after deprecation > + ((and (string? swap) (string-prefix? "/dev/mapper/" swap)) > + (list (symbol-append 'device-mapping- > + (string->symbol (basename swap))))) BTW, shouldn=E2=80=99t we emit a deprecation warning when (string? swap)? If we do, it should contain source location info, as discussed at . The whole series LGTM modulo the minor issues I commented on; could you send a last version? If Tobias agrees, we can apply that last version as soon as we get it. I=E2=80=99d even apply it to =E2=80=98master=E2=80=99; why did you target = =E2=80=98core-updates-frozen=E2=80=99? Thanks! Ludo=E2=80=99.