unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Liliana Marie Prikler <liliana.prikler@gmail.com>
Cc: 51755@debbugs.gnu.org, zimoun <zimon.toutoune@gmail.com>
Subject: [bug#51755] [PATCH 1/1] gnu: proof-general: Adjust autoloads for Emacs.
Date: Sun, 21 Nov 2021 21:15:30 +0100	[thread overview]
Message-ID: <87y25huuxp.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <6aab24bab9512e0957e33256a3addf1076a9d012.camel@gmail.com> (Liliana Marie Prikler's message of "Sun, 21 Nov 2021 20:07:48 +0100")

Hello,

Liliana Marie Prikler <liliana.prikler@gmail.com> writes:

> Am Sonntag, den 21.11.2021, 19:40 +0100 schrieb Nicolas Goaziou:

>> So, IIUC, the above is basically a hack: you disguise the main file
>> into an autoloads file because no autoloads file is generated from
>> the code base? If so, this might deserve a longer comment, IMO.

Actually, my assumption was wrong. "proof-general.el" is
a meta-autoloads file:

    ;; This file is a thin, package.el-friendly wrapper around generic/proof-site,
    ;; suitable for execution on Emacs start-up.  It serves two purposes:
    ;;
    ;; * Setting up the load path when byte-compiling PG.
    ;; * Loading a minimal PG setup on startup (not all of Proof General, of course;
    ;;   mostly mode hooks and autoloads).

> On a related note, what would be so bad about having to (require
> 'proof-general) interactively?

When not byte compiled, the file only does

  (require 'proof-site (expand-file-name "generic/proof-site" pg-init--pg-root)))

I guess we could also provide a single autoloads file doing just that
or, according to the manual,

  (load "PROOF-GENERAL-HOME/generic/proof-site.el")

> Alternatively, we could in an after-
> unpack phase add autoload cookies to the source file or write our own
> autoloads altogether.  WDYT?

Autoload cookies are already present in the code base, but in
sub-directories.

OTOH, I assume the solution proposed by Zimoun, as hackish as it is,
works well enough. And it requires less work. IMO, it is acceptable with
a good comment.

Regards,
-- 
Nicolas Goaziou




  reply	other threads:[~2021-11-21 20:16 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-10 19:26 [bug#51755] [PATCH 0/1] Fix ProofGeneral (emacs front-end for Coq) zimoun
2021-11-10 19:37 ` [bug#51755] [PATCH 1/1] gnu: proof-general: Adjust autoloads for Emacs zimoun
2021-11-21 18:40   ` Nicolas Goaziou
2021-11-21 19:07     ` Liliana Marie Prikler
2021-11-21 20:15       ` Nicolas Goaziou [this message]
2021-11-21 21:11         ` zimoun
2021-11-22 18:22           ` bug#51755: " Nicolas Goaziou
2021-11-21 22:17             ` [bug#51755] " zimoun
2021-11-19 12:27 ` [bug#51755] [PATCH 0/1] Fix ProofGeneral (emacs front-end for Coq) zimoun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y25huuxp.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=51755@debbugs.gnu.org \
    --cc=liliana.prikler@gmail.com \
    --cc=zimon.toutoune@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).