From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id yFTEDz6m82EqogAAgWs5BA (envelope-from ) for ; Fri, 28 Jan 2022 09:15:58 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id oA5KDD6m82EcDwAAauVa8A (envelope-from ) for ; Fri, 28 Jan 2022 09:15:58 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id BE6B134C64 for ; Fri, 28 Jan 2022 09:15:57 +0100 (CET) Received: from localhost ([::1]:43842 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nDMQG-00039h-It for larch@yhetil.org; Fri, 28 Jan 2022 03:15:56 -0500 Received: from eggs.gnu.org ([209.51.188.92]:46842) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nDMMU-0000zr-QS for guix-patches@gnu.org; Fri, 28 Jan 2022 03:12:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:36086) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nDMMU-0004EL-Fo for guix-patches@gnu.org; Fri, 28 Jan 2022 03:12:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nDMMU-0001Da-9w for guix-patches@gnu.org; Fri, 28 Jan 2022 03:12:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#53535] [PATCH] gnu: Add emacs-popper Resent-From: Nicolas Goaziou Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 28 Jan 2022 08:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53535 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Niklas Eklund Cc: 53535@debbugs.gnu.org Received: via spool by 53535-submit@debbugs.gnu.org id=B53535.16433575104656 (code B ref 53535); Fri, 28 Jan 2022 08:12:02 +0000 Received: (at 53535) by debbugs.gnu.org; 28 Jan 2022 08:11:50 +0000 Received: from localhost ([127.0.0.1]:57219 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nDMMH-0001Cy-W1 for submit@debbugs.gnu.org; Fri, 28 Jan 2022 03:11:50 -0500 Received: from relay3-d.mail.gandi.net ([217.70.183.195]:48423) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nDMMG-0001Ca-0k for 53535@debbugs.gnu.org; Fri, 28 Jan 2022 03:11:48 -0500 Received: (Authenticated sender: admin@nicolasgoaziou.fr) by mail.gandi.net (Postfix) with ESMTPSA id 2027E60014; Fri, 28 Jan 2022 08:11:40 +0000 (UTC) From: Nicolas Goaziou References: <87k0enmm8z.fsf@posteo.net> Date: Fri, 28 Jan 2022 09:11:39 +0100 In-Reply-To: <87k0enmm8z.fsf@posteo.net> (Niklas Eklund's message of "Tue, 25 Jan 2022 23:25:16 +0000") Message-ID: <87y230wa84.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1643357757; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=/BY/iJ2njegk1W130sSr7OzHdBUATxE990suzEXm3cg=; b=ZZjwHRhLOWQmKn+HGY8GeKAjX1SPoaHK9C9bfCNkspsUF/MMbnMuULzjDuM+X6Kyf8ZSHU VU1iG6+DJjGme5S2jt8u5TW7B1CI9UdHv4rotpnRxsNnBVf520VvZmINUNZy+lu/l6kvAw u0xyxTHXYiMEGrmDTcAeDGbM+Bb53fEnXHmexsYiv8GByoQIUUvWClxR7LctPGfAoFtsge vmkOMD6+4CxRAmh9SZiDqHXQ6h+JVSHwysxhHkSULeow1ZD5lZ646SCt4zNBvuWYvAi8yt XjRMlCOhqzAE6sFg33SRGsvzs9mo8ubUJT05cq7ASL188kY9gN1mojjUJHCZhw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1643357757; a=rsa-sha256; cv=none; b=ul+/AduArFDm1Vp1fnFoDtdhcoTQeMUIGwZnwNLkVkDGFol25fQTQQ9+BPJ5YB+NxG28/X lGCceQUPTKudQAGLCv0TnTOec6TZ2Ly1cWGjfIR9uCvkS/NgaB0QYLZkS3QBJKQIfJK84Q 83OmHWXp0J/gkWHo3pMyHBcEIWKhY/5ISlqsXz6jCR+rVeLYapPpV7BW2NouYP6onPnzko sUJBpHkfGsmby68dx1lZD4clEvKswkz8QmQfMTLACXFZ0Y7CW818swVtZcz2lAFL8xjTrM fkMg+V9SxQPVimcxgmf1dfLpU3LOKH7aL+E+QHBMlzvfPCRiuO+HNMNYtTyZyg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.23 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: BE6B134C64 X-Spam-Score: -3.23 X-Migadu-Scanner: scn1.migadu.com X-TUID: 544j1zw7ZohA Hello, Niklas Eklund writes: > this patch adds the emacs-popper package. Thank you. Somme comments follow.. > Subject: [PATCH] gnu: Add emacs-popper. The commit message is missing a line: * gnu/packages/emacs-xyz.scm (emacs-popper): New variable. > +(define-public emacs-popper > + ;; No tagged release upstream for version 0.45 This is true, but the commit matching release 0.45 is "851d83882192ac9599ac5b053614a42d683b3fab", not the one you're using. > + (let ((commit "527a85c49174e6e79220f0ed0761c204a979eae6") (revision "0")) Could you add a newline between (commit ...) and (revision ...)? > + (package > + (name "emacs-popper") > + (version "0.45") You bound revision, but you're not actually making use of it. I think there are two possibilities here: - if you use commit 851d83882192ac9599ac5b053614a42d683b3fab, you can keep using (version "0.45"), and explain in a comment that the chosen commit matches version bump; - if you use another commit, you need to use (git-version "0.45" revision commit) instead, and explain in a comment why you're using an untagged commit. Could you send an updated patch? Regards, -- Nicolas Goaziou