From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id CKHuJhf3FmKaJQEAgWs5BA (envelope-from ) for ; Thu, 24 Feb 2022 04:10:15 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id EPw9JBf3FmKcMgEA9RJhRA (envelope-from ) for ; Thu, 24 Feb 2022 04:10:15 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 421C03B5B1 for ; Thu, 24 Feb 2022 04:10:15 +0100 (CET) Received: from localhost ([::1]:38106 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nN4WE-0006yA-2L for larch@yhetil.org; Wed, 23 Feb 2022 22:10:14 -0500 Received: from eggs.gnu.org ([209.51.188.92]:48462) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nN4W4-0006w7-FG for guix-patches@gnu.org; Wed, 23 Feb 2022 22:10:04 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:53115) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nN4W4-0000hr-2Y for guix-patches@gnu.org; Wed, 23 Feb 2022 22:10:04 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nN4W3-00030G-Ux for guix-patches@gnu.org; Wed, 23 Feb 2022 22:10:03 -0500 Subject: bug#54132: [PATCH] gnu: imgui: Add missing build files. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-To: guix-patches@gnu.org Resent-Date: Thu, 24 Feb 2022 03:10:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 54132 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: John Kehayias Cc: 54132-done@debbugs.gnu.org Mail-Followup-To: 54132@debbugs.gnu.org, maxim.cournoyer@gmail.com, john.kehayias@protonmail.com Received: via spool by 54132-done@debbugs.gnu.org id=D54132.164567219411482 (code D ref 54132); Thu, 24 Feb 2022 03:10:03 +0000 Received: (at 54132-done) by debbugs.gnu.org; 24 Feb 2022 03:09:54 +0000 Received: from localhost ([127.0.0.1]:47003 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nN4Vt-0002z8-SU for submit@debbugs.gnu.org; Wed, 23 Feb 2022 22:09:54 -0500 Received: from mail-qk1-f173.google.com ([209.85.222.173]:44755) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nN4Vn-0002yc-Qo for 54132-done@debbugs.gnu.org; Wed, 23 Feb 2022 22:09:49 -0500 Received: by mail-qk1-f173.google.com with SMTP id q4so761098qki.11 for <54132-done@debbugs.gnu.org>; Wed, 23 Feb 2022 19:09:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=uxk5AaFvoko7oPVRAz6OVxyk0QDqhgkJ4yQT6NxauFY=; b=j5j1kHDqqJmyQYiE3Aea8FZfHjVHIBnQkZ5VKhXJahPhEO+IgLpDoCHMdW1lFR3VF/ OGann8xGp178cpaJwVsn830AyS21Ij9Ri34YknZNVJ2cW9WcA/IfOSLrzthSAu4nLbs0 j1SsSSgy07bNjEm+OBJJwicrTawB/APuETgBrnnUJ+oxmnEFcicFNpSxImhAuLgEOdfO 6CoSJInkP6aTyKH9GnyI9pTVnyPWlL59ovtL+1R+AOD3ORhKPpOYRSTUxw+Lfhk3wiUG /jVdhIAbthWDNkqgh6Tf9FVvb0dwFpYpQZyQRd3K79grZgUwGjm42vqO3d3iwBKr7yS+ 0WMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=uxk5AaFvoko7oPVRAz6OVxyk0QDqhgkJ4yQT6NxauFY=; b=AA6kNHeFRroIx+lfam9499/QcrEjhkUH/IQeJrrNi9zoOXcPcJRvkvhMU0uqN/qOQO p76Y43aXdcfSixnNRpQqXhVZKT+rHOLdfDunNFmRaa5QpkR3zCtNAc9VHM/1cP0LG9uV eixHWnzIkibRyunN3QwOMENm1E6xNkRONG6SW20LQT/CSXPsok3unJRoApK8Bm4nmV2Z XUjuyaRnMTMiFL7FopcwpZVsZcDhYj1SHwAZWMAP/DaET78XZX/VUr7edBbaT84jjTr1 9itVKXDw9H3DB3sp32hKC9hh4q9kmnFvcD9XjSeufrrFLaKGash5lRldh0nVB+J4Hjmn X1Mg== X-Gm-Message-State: AOAM530gISYr1oh7wWHKiyaaHtgKy/1NMYA+GtpH717pr4a00sZq+1Ja S8a+6nACGjfrysrFjfENk03sAJ7bBOA= X-Google-Smtp-Source: ABdhPJwrPbQilFN2PRIEZMyUEGs1i/LfjBh0Ju3+dmusCEy0an1HHHwnoxoPzdF4GWLEYYNy7COSug== X-Received: by 2002:a05:620a:20c8:b0:47b:4219:40d9 with SMTP id f8-20020a05620a20c800b0047b421940d9mr450883qka.224.1645672182157; Wed, 23 Feb 2022 19:09:42 -0800 (PST) Received: from hurd (dsl-156-1.b2b2c.ca. [66.158.156.1]) by smtp.gmail.com with ESMTPSA id v145sm751627qkb.63.2022.02.23.19.09.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Feb 2022 19:09:41 -0800 (PST) From: Maxim Cournoyer References: Date: Wed, 23 Feb 2022 22:09:41 -0500 In-Reply-To: (John Kehayias's message of "Wed, 23 Feb 2022 19:55:42 +0000") Message-ID: <87y221klje.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1645672215; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-to: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=uxk5AaFvoko7oPVRAz6OVxyk0QDqhgkJ4yQT6NxauFY=; b=kTwMvTZ3uFhQEpDL2eZf0vf1HH/gathZlCiFgaQb5tapIQ6jPnGbIZW/+BUKDe5i+G02Qt PTM9bpD+DihiVXjfbGuED/ykxQZY5BbuyYc747fQbLE46kS5eKnbeNj88B55Jcjdzwv/jd egUn+t/eE66+EvWNnSA6vft8wZBfL1tYuu9jx5kBCwcQwstA3sOcvRBgnocrvzvZpcaAvK sZQRWO354ChOk7xjGYMMMNP4X1ofnANwK568TrK5Abi6chfkXuGNIi/rijn4fC493KzhhQ /+OshOTi892JfrMTW7SY5reFsiVo9dI397baYw/RIs9Ft+RGHaoAWvswATvgyw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1645672215; a=rsa-sha256; cv=none; b=L9QIfIkMG3LTi+vqpmpjWytmRo1I3O2cq+pAp/5XtmvGEhDBxtFOUxtHgG4GCxXlBq/gov LjTIGBfCeyBsJ0qJRyfOqigFOGIInlRMNrPdIErIsYTf7GhUQzgK3IFr54gH25LQu2v0n0 I+FLMWveYlgqNPULmSuenmZafbBLXdXWBzjJ6+j8JXwbyOcCzu693Z4/HfTXWct9DkRjYx pdaRqxOSWmF0ylzIh5U8llmLOy2eOyPg8ZGEzZJWeG5ZP0OPvqJbwlUgTjPiZMtaCT539+ +k7UyMXjf+EuvvvskllPSC8pCU+pvLHOFYIjTEhwc+cNj2Y5tV0mFI6pSYUN7g== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=j5j1kHDq; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -2.03 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=j5j1kHDq; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 421C03B5B1 X-Spam-Score: -2.03 X-Migadu-Scanner: scn1.migadu.com X-TUID: P4IkaPX1reqp Hello! John Kehayias writes: > Imgui was being built without two of its files, removing table and > widget support from the built library. This simple patch adds them > back to the build phase. > > Tested it builds and those features work in a package (mangohud) that use= s them. > > From 11c8aa71d3e226b469e4ed3c65fd85851eb63f76 Mon Sep 17 00:00:00 2001 > From: John Kehayias > Date: Wed, 23 Feb 2022 14:51:32 -0500 > Subject: [PATCH] gnu: imgui: Add missing build files. > > * gnu/packages/toolkits.scm (imgui)[phases]: Add imgui_tables.cpp and > imgui_widgets.cpp to the build phase. > --- > gnu/packages/toolkits.scm | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/gnu/packages/toolkits.scm b/gnu/packages/toolkits.scm > index ee0cffa2f9..ba860014a4 100644 > --- a/gnu/packages/toolkits.scm > +++ b/gnu/packages/toolkits.scm > @@ -1,6 +1,7 @@ > ;;; GNU Guix --- Functional package management for GNU > ;;; Copyright =C2=A9 2022 Maxim Cournoyer > ;;; Copyright =C2=A9 2020 Tobias Geerinckx-Rice > +;;; Copyright =C2=A9 2022 John Kehayias > ;;; > ;;; This file is part of GNU Guix. > ;;; I've heard for contributions of less than about 10 new lines, the changes are not substantial enough to be protected by copyright. Something to keep in mind for your future patches :-). > @@ -69,6 +70,8 @@ (define-public imgui > "-o" "libimgui.so" > "imgui.cpp" > "imgui_draw.cpp" > + "imgui_tables.cpp" > + "imgui_widgets.cpp" > ;; Include the supported backends. > "backends/imgui_impl_glfw.cpp" > "backends/imgui_impl_sdl.cpp" Applied as 74f9c8e47f08826eff12b793e668d7e8c5898b0e. Thanks for the investigation and fix! Maxim