From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: John Kehayias <john.kehayias@protonmail.com>
Cc: 54132-done@debbugs.gnu.org
Subject: bug#54132: [PATCH] gnu: imgui: Add missing build files.
Date: Wed, 23 Feb 2022 22:09:41 -0500 [thread overview]
Message-ID: <87y221klje.fsf@gmail.com> (raw)
In-Reply-To: <pP6T2o9FJHYshP8_V83tR6Y_4yEfZgtnW5vlNcZ4Nwa7QC1FigKlK_-5nrjzCv-2AA4v3pppLOTEvWhG4OEPYCjprSaVj2P8cd4GMoFajNc=@protonmail.com> (John Kehayias's message of "Wed, 23 Feb 2022 19:55:42 +0000")
Hello!
John Kehayias <john.kehayias@protonmail.com> writes:
> Imgui was being built without two of its files, removing table and
> widget support from the built library. This simple patch adds them
> back to the build phase.
>
> Tested it builds and those features work in a package (mangohud) that uses them.
>
> From 11c8aa71d3e226b469e4ed3c65fd85851eb63f76 Mon Sep 17 00:00:00 2001
> From: John Kehayias <john.kehayias@protonmail.com>
> Date: Wed, 23 Feb 2022 14:51:32 -0500
> Subject: [PATCH] gnu: imgui: Add missing build files.
>
> * gnu/packages/toolkits.scm (imgui)[phases]: Add imgui_tables.cpp and
> imgui_widgets.cpp to the build phase.
> ---
> gnu/packages/toolkits.scm | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/gnu/packages/toolkits.scm b/gnu/packages/toolkits.scm
> index ee0cffa2f9..ba860014a4 100644
> --- a/gnu/packages/toolkits.scm
> +++ b/gnu/packages/toolkits.scm
> @@ -1,6 +1,7 @@
> ;;; GNU Guix --- Functional package management for GNU
> ;;; Copyright © 2022 Maxim Cournoyer <maxim.cournoyer@gmail.com>
> ;;; Copyright © 2020 Tobias Geerinckx-Rice <me@tobias.gr>
> +;;; Copyright © 2022 John Kehayias <john.kehayias@protonmail.com>
> ;;;
> ;;; This file is part of GNU Guix.
> ;;;
I've heard for contributions of less than about 10 new lines, the
changes are not substantial enough to be protected by copyright.
Something to keep in mind for your future patches :-).
> @@ -69,6 +70,8 @@ (define-public imgui
> "-o" "libimgui.so"
> "imgui.cpp"
> "imgui_draw.cpp"
> + "imgui_tables.cpp"
> + "imgui_widgets.cpp"
> ;; Include the supported backends.
> "backends/imgui_impl_glfw.cpp"
> "backends/imgui_impl_sdl.cpp"
Applied as 74f9c8e47f08826eff12b793e668d7e8c5898b0e.
Thanks for the investigation and fix!
Maxim
next prev parent reply other threads:[~2022-02-24 3:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-23 19:55 [bug#54132] [PATCH] gnu: imgui: Add missing build files John Kehayias via Guix-patches via
2022-02-24 3:09 ` Maxim Cournoyer [this message]
2022-02-24 3:35 ` John Kehayias via Guix-patches via
2022-02-24 14:13 ` Maxim Cournoyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y221klje.fsf@gmail.com \
--to=maxim.cournoyer@gmail.com \
--cc=54132-done@debbugs.gnu.org \
--cc=john.kehayias@protonmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).