From: Marius Bakke <marius@gnu.org>
To: matthieu.simonin@inria.fr, 57419@debbugs.gnu.org
Cc: msimonin <matthieu.simonin@inria.fr>
Subject: [bug#57419] [PATCH] gnu: add python-grid5000
Date: Mon, 29 Aug 2022 18:09:30 +0200 [thread overview]
Message-ID: <87y1v7c9qd.fsf@gnu.org> (raw)
In-Reply-To: <f4490ba376b8366d083f9be956d23e4fdea60e89.1661459445.git.matthieu.simonin@inria.fr>
[-- Attachment #1: Type: text/plain, Size: 1495 bytes --]
Hi Matthieu,
Welcome to Guix! The patch looks good overall, a few minor questions:
> +(define-public python-grid5000
> + (package
> + (name "python-grid5000")
> + (version "1.2.3")
> + (source (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url "https://gitlab.inria.fr/msimonin/python-grid5000")
> + (commit (string-append "v" version))))
> + (file-name (git-file-name name version))
> + (sha256
> + "097pm8b68ihk29xz9zv29b1x0bhgjb4lfj8zxk2grbsh7wr9dipg")))
> + (build-system python-build-system)
> + (native-inputs (list python-wheel))
> + (propagated-inputs (list python-requests python-ipython python-pyyaml))
> + (arguments
> + (list #:tests? #f))
Can you add a comment stating why tests are disabled?
> + (home-page "https://pypi.org/project/python-grid5000/")
> + (synopsis "Grid5000 python client")
> + (description
> + "python-grid5000 is a python package wrapping the Grid5000 REST API.
> + You can use it as a library in your python project or you can
> + explore the Grid5000 resources interactively using the embedded shell.")
> + (license license:gpl3)))
The LICENSE.txt file says LGPL3, setup.cfg says GPL3. Which is
correct? :-)
Also, unless otherwise noted in the source code (e.g. "version 3 only"),
it should be "gpl3+", i.e. "and any later version".
Can you send an updated patch?
Thanks in advance!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 247 bytes --]
next prev parent reply other threads:[~2022-08-29 16:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-25 20:30 [bug#57419] [PATCH] gnu: add python-grid5000 matthieu.simonin
2022-08-29 16:09 ` Marius Bakke [this message]
2022-08-30 9:00 ` matthieu.simonin
2022-08-30 16:00 ` bug#57419: " Marius Bakke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y1v7c9qd.fsf@gnu.org \
--to=marius@gnu.org \
--cc=57419@debbugs.gnu.org \
--cc=matthieu.simonin@inria.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).