From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id uCrfFZXnEGP5AQEAbAwnHQ (envelope-from ) for ; Thu, 01 Sep 2022 19:10:45 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id oIjQFZXnEGP68wAA9RJhRA (envelope-from ) for ; Thu, 01 Sep 2022 19:10:45 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 062EDE8D8 for ; Thu, 1 Sep 2022 19:10:44 +0200 (CEST) Received: from localhost ([::1]:40164 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oTniF-0004DM-VR for larch@yhetil.org; Thu, 01 Sep 2022 13:10:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59870) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oTnOE-0007aD-Fy for guix-patches@gnu.org; Thu, 01 Sep 2022 12:50:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:54282) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oTnOE-0005Ci-7E for guix-patches@gnu.org; Thu, 01 Sep 2022 12:50:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oTnOD-00070X-Vh for guix-patches@gnu.org; Thu, 01 Sep 2022 12:50:01 -0400 Subject: bug#57513: [PATCH] installer: Fix segfault on double logical partition removal. Resent-From: Mathieu Othacehe Original-Sender: "Debbugs-submit" Resent-To: guix-patches@gnu.org Resent-Date: Thu, 01 Sep 2022 16:50:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 57513 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Josselin Poiret Cc: 57513-done@debbugs.gnu.org Mail-Followup-To: 57513@debbugs.gnu.org, othacehe@gnu.org, dev@jpoiret.xyz Received: via spool by 57513-done@debbugs.gnu.org id=D57513.166205094326857 (code D ref 57513); Thu, 01 Sep 2022 16:50:01 +0000 Received: (at 57513-done) by debbugs.gnu.org; 1 Sep 2022 16:49:03 +0000 Received: from localhost ([127.0.0.1]:44029 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oTnNH-0006z6-0b for submit@debbugs.gnu.org; Thu, 01 Sep 2022 12:49:03 -0400 Received: from eggs.gnu.org ([209.51.188.92]:48078) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oTnNG-0006ye-4o for 57513-done@debbugs.gnu.org; Thu, 01 Sep 2022 12:49:02 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:36488) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oTnNA-00058Y-NW; Thu, 01 Sep 2022 12:48:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=UZ83+gW+XbOCOgIb/H461ofCOltubg5pwMdOngHbsxU=; b=OmRalB7j2HRyZ5Wfti4A Ua9ORZm7SzrK5iyE456y1APz5RMmksYZDoEyTXopIUveySW45Af2n0Rw5ATRImAPwJAa4Mx/BERtK OLu5VaJUDXx2ZAtxzjLDHdVuFCB23th7akLamm77lC+rdxPe4QfTKGPnKapqNtCvFnr4XjQS3jNpR VXu7rN8Fnz5uF3bvGjlcmQKFozFONZk9WHEw8b8UZka6u3v9GIdpZIB2uCzDJJc962YEOBU4BXEN5 Zyu/Iio8KlybmMN2bDohOIEWauwFLLY7VLQTCbMgItpAVL9tUSnxM/d1litNB0lO/GP7xYmOIKY8S r5ZcMt3N/OoNFA==; Received: from pop.92-184-97-57.mobile.abo.orange.fr ([92.184.97.57]:37502 helo=meije) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oTnN9-0000g5-9b; Thu, 01 Sep 2022 12:48:56 -0400 From: Mathieu Othacehe References: Date: Thu, 01 Sep 2022 18:48:51 +0200 In-Reply-To: (Josselin Poiret's message of "Wed, 31 Aug 2022 23:22:55 +0200") Message-ID: <87y1v32g7g.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1662052245; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-to:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=UZ83+gW+XbOCOgIb/H461ofCOltubg5pwMdOngHbsxU=; b=rikM+4d5uKpggCD3d5zrseVXkr3kHUYNDii5KTcj7PSwB0kG5LIzUhB7V98ctpKeyQHQnS kPZlrx2ZypHdMxNadHgaPxiJorEDh7Mqq6dMHfiJxsl0aD34kvuhs0D/Tra3IL1nDWpWYA 9g1CJaQ/7F90P7tezZJv430zGP+Zc8v9nDdtzHhEUyW7Tfp+Li9xO7gAhspusOZ64aXhiA s8zLiLb7vkcE6oY1KByV3To4+RkTkrZnjpd/PYdyJv8314xOLOIqi0MnLF+yWAXv/ZAfJT pzabwVAl0LI0tRYzh6RU6szCv++WkZgcc51Nett/bJ/Nzarz2LZICLK7Hu4GGg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1662052245; a=rsa-sha256; cv=none; b=XO/jq6QjCWDDedwxDYdaTZRjfjA9aebpmARzkCcKuWtb67wBRvh68toekUSLtgfsgSpJFC uB34MiQwDOsdpYJ0GtEhLsRqONGJ0H5BR4ZU461PyUyKPDqoJ6b9xIpxOJltCT2BeeU4Ae eaLYVXurqkD1P6TqpfgbqFJUZH28lT1hx+XmLuAm9FEG935VhdUkUesr5XI2C3aFDaaw7j aGDXBv75QYxUXdpEVG+/G9qHewsIVzJH/VwbmN3/IAgxuOq2SaHFeKVUFxpQTmVMyh8gvN HCop06xlaQeSBtN50J5eMpq7lrB5qwcMHgL+AUeVrjRD0CdxYZHnz+ZXsl9v4Q== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=OmRalB7j; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.68 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=OmRalB7j; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 062EDE8D8 X-Spam-Score: -3.68 X-Migadu-Scanner: scn1.migadu.com X-TUID: 4B6Sf2+I+grx Hey, > * gnu/installer/parted.scm (auto-partition!): Avoid removing logical > partitions twice. I was able to reproduce the issue by creating an extended partition containing a single logical partition using the manual partitioning tool then, the automatic one right after. It resulted in a segfault, which is fixed by your patch, that's a very nice catch! Pushed as 4989f6acff3b3fcfbd9dde3e3c2767bd2cd6d49e. Thanks, Mathieu