unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Trevor Richards <trev@trevdev.ca>
Cc: 57773-done@debbugs.gnu.org
Subject: bug#57773: [PATCH] gnu: add emacs-transpose-mark
Date: Sun, 18 Sep 2022 11:26:47 +0200	[thread overview]
Message-ID: <87y1uhyqw8.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <4cf1bdb4958b51e84246995340c3f4322d3629da.1663273749.git.trev@trevdev.ca> (Trevor Richards's message of "Tue, 13 Sep 2022 08:21:37 -0700")

Hello,

Trevor Richards <trev@trevdev.ca> writes:

> +(define-public emacs-transpose-mark
> +  (let ((commit "667327602004794de97214cf336ac61650ef75b7")
> +        (revision "0"))

Thank you. I normalized your commit message and applied your patch with
the changes below.

> +    (package
> +      (name "emacs-transpose-mark")
> +      (version (git-version "0.0.1" revision commit))

Base version is actually "0": I couldn't find any tag nor a Version keyord. 

> +         (uri (git-reference
> +               (url "https://github.com/kwrooijen/transpose-mark.git")

I removed the ".git" suffix.

> +      (home-page "https://github.com/kwrooijen/transpose-mark.git")

Ditto.

> +      (synopsis "A small library for transposing lines and regions.")

Synopsis are not expected to start with an article, nor end with a full
stop.

> +      (description "Transpose mark provides some commands that makes
> +transposing lines and regions easier. You can mark a line and transpose it
> +with a line at point, or \"mark\" a region and transpose it with another
> +region a point. The plugin provides visual feedback for marked
> regions.")

I added two spaces between sentences.

> +      (license license:gpl3))))

License is "gpl3+": it contains "or (at your option) any later version"

Regards,
-- 
Nicolas Goaziou




      reply	other threads:[~2022-09-18  9:27 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-13 15:21 [bug#57773] [PATCH] * gnu/packages/emacs-xyz.scm: Added emacs-transpose-mark Trevor Richards
2022-09-13 15:21 ` [bug#57773] [PATCH] gnu: add emacs-transpose-mark Trevor Richards
2022-09-18  9:26   ` Nicolas Goaziou [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y1uhyqw8.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=57773-done@debbugs.gnu.org \
    --cc=trev@trevdev.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).