From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id aD+EM2/eNGMRHgAAbAwnHQ (envelope-from ) for ; Thu, 29 Sep 2022 01:53:19 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id +GGqMm/eNGMpZAEAG6o9tA (envelope-from ) for ; Thu, 29 Sep 2022 01:53:19 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 83A17392C5 for ; Thu, 29 Sep 2022 01:53:19 +0200 (CEST) Received: from localhost ([::1]:41692 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1odgre-0006XL-NC for larch@yhetil.org; Wed, 28 Sep 2022 19:53:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40214) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1odgrP-0006PS-45 for guix-patches@gnu.org; Wed, 28 Sep 2022 19:53:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:36113) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1odgrO-0005Nz-PF for guix-patches@gnu.org; Wed, 28 Sep 2022 19:53:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1odgrO-0006pY-9K for guix-patches@gnu.org; Wed, 28 Sep 2022 19:53:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#49128] [PATCH] services: Add file system utilities to profile. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 28 Sep 2022 23:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49128 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 49128-done@debbugs.gnu.org, Brice Waegeneire Received: via spool by 49128-done@debbugs.gnu.org id=D49128.166440914126178 (code D ref 49128); Wed, 28 Sep 2022 23:53:02 +0000 Received: (at 49128-done) by debbugs.gnu.org; 28 Sep 2022 23:52:21 +0000 Received: from localhost ([127.0.0.1]:35185 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1odgqi-0006o9-KP for submit@debbugs.gnu.org; Wed, 28 Sep 2022 19:52:20 -0400 Received: from mail-qk1-f182.google.com ([209.85.222.182]:35609) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1odgqg-0006nu-UN for 49128-done@debbugs.gnu.org; Wed, 28 Sep 2022 19:52:19 -0400 Received: by mail-qk1-f182.google.com with SMTP id u28so8901939qku.2 for <49128-done@debbugs.gnu.org>; Wed, 28 Sep 2022 16:52:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date; bh=MCHEdM5zen1hC1ZaKmrBiL/we2UUGm/UsIOrrfC7QWE=; b=Br+YM9nfBSpV0UgosAGLnuq8NeBvFk7XHjx8i+s8z6GWku6OB/0r/0ZjMYspBeR6vg RKkQW3fINuWxfC+W55dTlHXuQ6cfcOn32y8i1OGaxlCDM4VLngzG2ow+wJmNXY71rrAi WyIfvasZtbenAh3kxgwrDZrMcKjwEjTdqw8/gEkIm5NbiCP0fYTUzX3U2teEFdI42z3O Pwf9QPG+ffoxvifrZiPSwvacS8lZruBrnahyK8qhnC9DWye2RyuCb4ZYiCcOLP3fzP/9 8nOI/z8T9vXgqyU5TXo2tHSdyVwr8+UxBSqXuM8bu8l4S+YIucfdx7If9N8uo75MYb24 NCjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date; bh=MCHEdM5zen1hC1ZaKmrBiL/we2UUGm/UsIOrrfC7QWE=; b=kyQlDZ5/NOA7iQmODpmI43z1FfEMSJu5sZqN/brSt36vQEzhy1uY2q6QOCPAjurbLt gCyGYRGLVrTzRngLHvWLYF/BagSinzDvK7KXTjm4UrXMI4Zb0SiLkFLHVv3EZLbMccEa Q1mQ0KfgqEI9B6WHrZWKQAM/Pf/xW/JUBOr2eiUgGGt+7Hx0MZ278sC/DoNlaAl15wpl tmcdYfk0PjU0x2ONRBuz4e2l90d8F4UQ1AoZr2LoUvmQTaYyZ+7KlG79YhN1LluSQO5s ayLCtx/bKvfbkZblomO7M4jmLlY1PAM2ljItEFOJA41SxelexuCSOLjscqgcYGqgawub QKYw== X-Gm-Message-State: ACrzQf34t9H/zHZAoY6PAYDMMEIxuIeRyHrhLUf7hP33yrXDK3VkiqQF AHExEwOV4OlTuId/VGXq/5JAzH5qN4gEaA== X-Google-Smtp-Source: AMsMyM68c+9hjK0Wwi2Oeuk0oan8V5a8VmTAP/Y1GkgICldEvLGfJlkjrFkgBkveg4h1lWFXjsHapg== X-Received: by 2002:a05:620a:19a5:b0:6cf:4a24:cccb with SMTP id bm37-20020a05620a19a500b006cf4a24cccbmr446365qkb.376.1664409133177; Wed, 28 Sep 2022 16:52:13 -0700 (PDT) Received: from hurd (dsl-148-95.b2b2c.ca. [66.158.148.95]) by smtp.gmail.com with ESMTPSA id fv10-20020a05622a4a0a00b003445bb107basm4007405qtb.75.2022.09.28.16.52.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Sep 2022 16:52:12 -0700 (PDT) From: Maxim Cournoyer References: <20210620100945.15345-1-brice@waegenei.re> <87lf6zrmot.fsf@gnu.org> Date: Wed, 28 Sep 2022 19:52:11 -0400 In-Reply-To: <87lf6zrmot.fsf@gnu.org> ("Ludovic =?UTF-8?Q?Court=C3=A8s?="'s message of "Thu, 24 Jun 2021 23:13:06 +0200") Message-ID: <87y1u3qcpg.fsf_-_@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1664409199; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=MCHEdM5zen1hC1ZaKmrBiL/we2UUGm/UsIOrrfC7QWE=; b=FbSgAUXagMVquHpP2xYW++lKYvObW2ABP0W4wvRGa0uQoWmFknGtqP6H9M4ZYej/Ij1okC lKiAUDn460IK3WcbpSYzTaJ+FEdgKBSztAyfXGF1ms6IXWWFljIB4/yv5mAQsYORoax7De dByHYGahR0f7zqOaCHAFQSQ6rr3e93kWkgOzrNlSb78ReNnqGeaTtbXTXQRdDEVpE3osW3 sNY3XxfuGYeooTmt2s1X4JZh61CK4/8XsA1SESAGQ9uJqArB5aW9bi/n2JfXahRiEZRTtU EY6ibMAXIEg3pp8uvYBjuzYHITFtZSFsqh9gnZl7RGoVOzQULpIuNw4P2Jpllg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1664409199; a=rsa-sha256; cv=none; b=u87cEae4HmwFJfU/D6TslzQsNg/h9hsYsXUE8QNsB2E7yu1mq6YUP3qLwYi+FXGbJgokpn ryGe0B8mfnclZePW3Dcfl9sp7aZQptzWpQCqDCh+iE5DgcoA7lCwPuI8EKjO1mR8v+QZnq 1PdYH1z1TtyTIU6R84fvNeaO5fjvSPHAQkvplKnBxrH8v5cjVxRzoF8eKs+Tmh48amDD4o 8CWQNfEkxnL3gJpxOGaW21xgFFsBjZpoTTnIYNJ3S9bGTuFbd/ASXuzhI/PFX0Yj6RNKdf 5rjLOF5rGUfjU/zydN2kZ9n1zWR/8p3vscZaLQp0dsV8rl/9XQGNEJCcHiyLdg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=Br+YM9nf; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 5.85 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=Br+YM9nf; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 83A17392C5 X-Spam-Score: 5.85 X-Migadu-Scanner: scn0.migadu.com X-TUID: 6cN+ryUaJikJ Hello, Ludovic Court=C3=A8s writes: > Hi, > > Brice Waegeneire skribis: > >> Fixes . > > Thanks for looking into it! > >> * gnu/services/base.scm (file-system-type->utilities, >> file-system-utilities): New procedures. >> (file-system-service-type): Extend 'profile-service-type' with >> 'file-system-utilities'. >> * gnu/system.scm (boot-file-system-service): New procedure=E2=80=A6 >> (operating-system-default-essential-services): =E2=80=A6use it. >> (%base-packages): Remove 'e2fsprogs'. >> * gnu/system/file-systems.scm (file-system): Add 'utilities?' field. > > I think is not a good place to specify whether one would > like utilities to be installed; records represent > mountable file systems, and utilities installed in the profile are > conceptually unrelated. > > Perhaps =E2=80=98file-system-service-type=E2=80=99 could extend =E2=80=98= profile-service-type=E2=80=99 > unconditionally, after all? I took out the utilities? field on (made it unconditional as suggested above), and pushed! Closing. Thanks for the addition! Maxim