From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id iI9/GMDiWmMCEAAAbAwnHQ (envelope-from ) for ; Thu, 27 Oct 2022 21:57:52 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id qJ3jF8DiWmMzLQAAG6o9tA (envelope-from ) for ; Thu, 27 Oct 2022 21:57:52 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 15675B5C6 for ; Thu, 27 Oct 2022 21:57:52 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oo8xQ-000119-TD; Thu, 27 Oct 2022 15:54:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oo8xG-0000qU-Jx for guix-patches@gnu.org; Thu, 27 Oct 2022 15:54:18 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oo8ch-0004DQ-0A for guix-patches@gnu.org; Thu, 27 Oct 2022 15:33:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oo8cg-0006nZ-C3 for guix-patches@gnu.org; Thu, 27 Oct 2022 15:33:02 -0400 Subject: bug#58587: [PATCH 04/14] build-system: Add pyproject-build-system. Resent-From: Marius Bakke Original-Sender: "Debbugs-submit" Resent-To: guix-patches@gnu.org Resent-Date: Thu, 27 Oct 2022 19:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 58587 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxim Cournoyer Cc: 58587-done@debbugs.gnu.org, Lars-Dominik Braun Mail-Followup-To: 58587@debbugs.gnu.org, marius@gnu.org, marius@gnu.org Received: via spool by 58587-done@debbugs.gnu.org id=D58587.166689915626094 (code D ref 58587); Thu, 27 Oct 2022 19:33:02 +0000 Received: (at 58587-done) by debbugs.gnu.org; 27 Oct 2022 19:32:36 +0000 Received: from localhost ([127.0.0.1]:59402 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oo8cG-0006mo-Ep for submit@debbugs.gnu.org; Thu, 27 Oct 2022 15:32:36 -0400 Received: from eggs.gnu.org ([209.51.188.92]:47158) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oo8cE-0006mY-2s for 58587-done@debbugs.gnu.org; Thu, 27 Oct 2022 15:32:34 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oo8c8-00044V-Gp; Thu, 27 Oct 2022 15:32:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=du1mpWNAwoH6xRFQDacj+kU6f9TCFrU4ZF/HXEijwX4=; b=GIdi66Cm26DZDpKYNGR0 zjvIGu2O6aAOAwUrcceqRHYPlHRnxuuhTxd8qOJ2sYGGg1bY+g0O6LjawNEsZ3ZR+U4r0Gd2dZt4Y WsQT2R8j6B22j+as2dxZ6PriJXMq/6djp+MvGbJGKkpPBq6sCkE/WdhG39+RNiFmKrwHfHkuVoVZc j2T/d2x1tgTGb3+kwAuK4mddffvQCweLaS/YP/BaBgFGoyLtmDz/TEFcgYjuP8vfCHr0fxIN8+s0Z Jl3+vdlvCtsFLCsGDjXZpXap//Cpk2/NF9+JYCtoUOheD7swtdGqSXxRmqjzPPFcJMyFRYSn0X6rc ebv/aNxqHwDL5Q==; Received: from [84.214.173.6] (helo=localhost) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oo8c8-0006Fg-2N; Thu, 27 Oct 2022 15:32:28 -0400 From: Marius Bakke In-Reply-To: <871qqttc3d.fsf@gnu.org> References: <20221017200624.4076-1-marius@gnu.org> <20221017201201.4808-1-marius@gnu.org> <20221017201201.4808-4-marius@gnu.org> <87zgdhjqgr.fsf@gmail.com> <871qqttc3d.fsf@gnu.org> Date: Thu, 27 Oct 2022 21:32:23 +0200 Message-ID: <87y1t1rrjs.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Guix-patches" Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1666900672; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-to:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=du1mpWNAwoH6xRFQDacj+kU6f9TCFrU4ZF/HXEijwX4=; b=Bf+N0cB7xNEnn2tyP6siOXinE5X5LOvC+oEFu+C0Ey1IAm80jdfQY10F+GuSfd+IlvcR8V 5gtYG1WPyzQ73Dkr3rRZBsLtK0ApeW3sB+mf42EMBhKXhcNXufWa1bbGPLjCkDNEbbjO0V jHxsyNJ9v9agLoGQMdXppb4KV1CGVXP7iNcHPn/+OQBpLDEIFfi9TvU9nq4YYZxSDMfDWt knBgKD51RCbMz0i78huvRuVWjRjdoz9kJZE/iTP6Eq6A7zBOFnwAwSrMy06fAmZ0nnB2t1 EAsBwcVrXJViksuHx231NPPkOPv6aZWY7rlwgaA759M5k3mc5ULxwskLZCf+Hw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1666900672; a=rsa-sha256; cv=none; b=Scu532DEpBq8CNPkrC2FxFeLMoByGNphXYri0OFGm2sUpkEyRKO0Cb3GqxT4mBNriMe0lQ EzjpykuTjMkPeW3amQCCjA5AssgDbqNnsU9uczYHUtCrN2juSrr7FoXarobY6SFCsQDV+n kOBZYu2aP/YLsZ1n673YGm3NzieFFWCkYSbm+kVlGD4KQaNCEHTeYXlWBsf1EFkdFp0JB4 WJfBtMrxF6/jBEPr+LOQ868r/X0WJI+ac5XGlaE1qcy5MvY0DTkz+i6xTk4n1cWv1+ywJw 0WHpWVUjmUwNjTgmAR/vqykEWcpRNhZL5iwMHw/OgzljZJBMm89V3sD6jsgWTA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=GIdi66Cm; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -4.41 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=GIdi66Cm; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 15675B5C6 X-Spam-Score: -4.41 X-Migadu-Scanner: scn1.migadu.com X-TUID: NdrmftkCQq7V --=-=-= Content-Type: text/plain Marius Bakke skriver: > Maxim Cournoyer skriver: > >> Hello, >> >> Marius Bakke writes: >> >>> From: Lars-Dominik Braun >>> >>> + ;; Prefer pytest >>> + (if pytest 'pytest #f) >>> + (if nosetests 'nose #f) >>> + (if nose2 'nose2 #f) >>> + ;; But fall back to setup.py, which should work for most >>> + ;; packages. XXX: would be nice not to depend on setup.py here? fails >>> + ;; more often than not to find any tests at all. Maybe we can run >>> + ;; `python -m unittest`? >>> + (if have-setup-py 'setup.py #f)))) >>> + (format #t "Using ~a~%" use-test-backend) >>> + (match use-test-backend >>> + ('pytest >>> + (apply invoke (cons pytest (or test-flags '("-vv"))))) >>> + ('nose >>> + (apply invoke (cons nosetests (or test-flags '("-v"))))) >>> + ('nose2 >>> + (apply invoke (cons nose2 (or test-flags '("-v" "--pretty-assert"))))) >> >> I think I'd leave the defaults in and document it that way. > > By leave, you mean: > > (apply invoke "pytest" "-vv" test-flags) > > ? I made this change in e944734ef9afa1ac9b46579934482b7d909ed24e. The patches are now merged! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iIUEARYKAC0WIQRNTknu3zbaMQ2ddzTocYulkRQQdwUCY1rcyA8cbWFyaXVzQGdu dS5vcmcACgkQ6HGLpZEUEHcvpgD7BBeyt/iHzCso8yd5ux/VzyUK4HhiLu8JT8hG z8wqXlIBAJMlLJQUM506e+rpLjPY437A8dzx0iQOlWM7hqd1oMQA =izOh -----END PGP SIGNATURE----- --=-=-=--