From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id 0H0PFodgxWN1IQEAbAwnHQ (envelope-from ) for ; Mon, 16 Jan 2023 15:34:47 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id IDb9FYdgxWPsswAAauVa8A (envelope-from ) for ; Mon, 16 Jan 2023 15:34:47 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id DB0742B24F for ; Mon, 16 Jan 2023 15:34:46 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pHQYy-0003EQ-Cg; Mon, 16 Jan 2023 09:34:16 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pHQYl-00034Z-6k for guix-patches@gnu.org; Mon, 16 Jan 2023 09:34:05 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pHQYk-0006i3-Cf for guix-patches@gnu.org; Mon, 16 Jan 2023 09:34:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pHQYk-0006Rf-7P for guix-patches@gnu.org; Mon, 16 Jan 2023 09:34:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#59762] Add serial-studio Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 16 Jan 2023 14:34:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59762 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: phodina Cc: 59762@debbugs.gnu.org Received: via spool by 59762-submit@debbugs.gnu.org id=B59762.167387963924767 (code B ref 59762); Mon, 16 Jan 2023 14:34:02 +0000 Received: (at 59762) by debbugs.gnu.org; 16 Jan 2023 14:33:59 +0000 Received: from localhost ([127.0.0.1]:60983 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pHQYg-0006RO-T1 for submit@debbugs.gnu.org; Mon, 16 Jan 2023 09:33:59 -0500 Received: from mail-qt1-f174.google.com ([209.85.160.174]:34566) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pHQYd-0006R8-E4 for 59762@debbugs.gnu.org; Mon, 16 Jan 2023 09:33:57 -0500 Received: by mail-qt1-f174.google.com with SMTP id e8so3763617qts.1 for <59762@debbugs.gnu.org>; Mon, 16 Jan 2023 06:33:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=AJFs0Sq8wAOb+LBAgul3yNNF/XHQ3toEo3huqSAJBA4=; b=GJajwwzd+YOGH+W8jyiLXoAe6DfYEen9Ijar3BKrdbSnahuaB+sb93wNjN9A5fGg6y DFWeWc+i6bzSkXbySeipaB8zfeEfkXrtyC6FfhjEa3FTGnpi2+dt+9mEQYQa+KLyCzM8 zussfP4RMhjMcNJE5YkcATzVXaspZt/Ws8RkV1qHkYUagKlNdHSaLp8l0fjAkQINEpTa EhogE0z3FahVf2POIIprNdXsD0V35jKWIR5+ckr0s97ka0UcRKURiu0k2NiYzE+x6zEr eHwyE/dLJCvTKJ8vbJvz3Ol5lEA3CdkID5MGFnteFB8v2JUv9qnK5/Qz0VSgfbFTfd5b IMMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=AJFs0Sq8wAOb+LBAgul3yNNF/XHQ3toEo3huqSAJBA4=; b=z0Lh5ZVoGvEQR2yrWSHeS3vBvccjvijUyopoEidwLHim5yOEtSVLlMHBgBDSP6+y0l u1TFDsp7w66DA0YLKy8DLCgkqgvNGKepXxedN50BnMjDNdoXXe82PBPbCcMaDvJ/fHJP FqNhFbOFlQzU4UIoBVMXfo3HU2wi9NKgx+JJffV6Qc1FFXr8bkDlBIorIoBJbBqlfeqJ JJyr3Y7yHQ4ld4YvNOIruONbnGrPA019sLKULAPhLA3LGajIJktNpIMpNckuuPtlcYHm 5k1LEckMlF92CCwykdLa15sQL+4gOs2lwOK5HVeAfWRasY+19gYHkRuTVNEG5Nj8FRIx 0aYw== X-Gm-Message-State: AFqh2kobgU47yWAl9KCd1IRx/Gm1hHRyQW6udjMNKLxl6vm3bRosU9AF gIXk0rtLSqNfKlFzIV60mQQu2wVMTGTgm8wZ X-Google-Smtp-Source: AMrXdXsc9k/PIoN8LxYdZipKCxfE3Kk7ApKQ7XnZEzRD0OkLgIjijQwzhj3DY6ezcGuuAm6QVZ7+yw== X-Received: by 2002:ac8:60d9:0:b0:3b2:1003:37e5 with SMTP id i25-20020ac860d9000000b003b2100337e5mr19351311qtm.55.1673879629626; Mon, 16 Jan 2023 06:33:49 -0800 (PST) Received: from hurd (dsl-10-130-209.b2b2c.ca. [72.10.130.209]) by smtp.gmail.com with ESMTPSA id x10-20020ac87a8a000000b003a7eb5baf3csm14524229qtr.69.2023.01.16.06.33.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Jan 2023 06:33:49 -0800 (PST) From: Maxim Cournoyer References: Date: Mon, 16 Jan 2023 09:33:48 -0500 In-Reply-To: (phodina@protonmail.com's message of "Fri, 02 Dec 2022 05:29:47 +0000") Message-ID: <87y1q2a6r7.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=GJajwwzd; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1673879687; a=rsa-sha256; cv=none; b=DlhS7JlrhMEyIBk+WIj6E+EcpzWEbLVs0aX9hkbbdwLLDNnNAB4VembqUyGHAT4HTLHJ+V uhcgiWF/TtSxRk7pJ/FwhwJczuvqVYgc0JT/mYse7N9lYqOmiVU795svVDEXfw4Z4Y7jze bu8nW7UW32UJ7a3/J3c45GlNXmL9MxCZIMhVBfTR3lCbAw/l1U17aldOlYN9vkXU9i1BuE RlxX6Rrze7/3NO+yEeNzvA2Wqfkzwk+5j2IuzmfsysKxOitcY5r8fzb9M8tuwKJVq5G/93 PvT/mAoGJPm2RLeJrD6SzLekJy/4yolYG8QyyMH4JYtz0QIkls23QafJFdqlDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1673879687; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=AJFs0Sq8wAOb+LBAgul3yNNF/XHQ3toEo3huqSAJBA4=; b=KYmZIZXL8L1AT4nm+rDs9r0LvP5+2GYoTL0WvP+a6ma07TgI08BsLjh8aWZMBsfe6MjKkl hCjvMCQxo3EFS3WWDoKqQIzj/txDRseKMGJ3MFzeYtTDZoKsyLji2u8er9t9i85qwk5xSl xHzgEL/6lR7gesHua/GEaRPJY54fKS7MYKiWDsgk8nOajybIkN28k2HPoj1mB3waRwB4BW Cdy8ItEM9XrPDAPWSFhMe/S59yUQ5SziXisF98DI+lN4yRvuX6U/gSJ4oskaF/SxFaZHbx FvH2II8CA2kg7FK/NQfFjdGSp9bodTA/H4/15MZdNiBFQTJ44D7R1jOAEIpwsg== X-Migadu-Queue-Id: DB0742B24F X-Migadu-Scanner: scn0.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=GJajwwzd; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) X-Migadu-Spam-Score: -2.83 X-Spam-Score: -2.83 X-TUID: iFibvy42VdD7 Hello! Reviewing patch 2/4. phodina writes: > Hi, > > this adds a nice GUI program to monitor communication on serial interfaces (e.g. UART). > > ---- > Petr > > From 367d7da4a143949d11fbc76495f935dff7a3f25c Mon Sep 17 00:00:00 2001 > From: Petr Hodina > Date: Sun, 16 Jan 2022 17:59:22 +0100 > Subject: [PATCH 1/4] gnu: Add qmqtt. > > * gnu/packages/qt.scm (qmqtt): New variable. > > diff --git a/gnu/packages/qt.scm b/gnu/packages/qt.scm > index 30bf429897..6aaa9c47c2 100644 > --- a/gnu/packages/qt.scm > +++ b/gnu/packages/qt.scm > @@ -3363,6 +3363,68 @@ (define-public python-qt.py > bindings (PySide, PySide2, PyQt4 and PyQt5).") > (license license:expat))) > > +(define-public qmqtt > + (package > + (name "qmqtt") > + (version "1.0.0") > + (source (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/alex-spataru/qmqtt") > + (commit (string-append "v" version)))) > + (file-name (git-file-name name version)) > + (modules '((guix build utils) (ice-9 ftw) > + (srfi srfi-1))) Only (guix build utils) is needed. > + (snippet `(begin > + (delete-file-recursively "tests/gtest/gtest"))) Extraneous 'begin' directive. > + (sha256 > + (base32 > + "1l96cssa9hjmabds9k9nzisxnzr3ndi3r82m3lgwq9ip94kz05nw")))) > + (build-system cmake-build-system) > + (arguments > + `(#:phases (modify-phases %standard-phases Please use plain list + gexps for new packages. > + (replace 'configure > + (lambda* (#:key outputs #:allow-other-keys) > + (invoke "qmake"))) Extraneous OUTPUTS argument. > + (replace 'install > + (lambda* (#:key outputs source #:allow-other-keys) > + (let* ((out (assoc-ref outputs "out")) (lib (string-append > + out "/lib")) > + (include (string-append out "/include"))) After switching to gexps, use gexp variables such as #$output. Extraneous SOURCE argument. > + (mkdir-p lib) > + (mkdir-p include) > + (chdir "..") ;we were in dir tests Prefer active tense (;navigate up from test directore), avoid 'we' as much as possible. > + (copy-recursively "lib" lib) > + (chdir "src/mqtt") > + (for-each (lambda (file) > + (install-file (string-append file) include)) > + '("qmqtt_client.h" "qmqtt_frame.h" > + "qmqtt_global.h" > + "qmqtt.h" > + "qmqtt_message.h" > + "qmqtt_networkinterface.h" > + "qmqtt_routedmessage.h" > + "qmqtt_router.h" > + "qmqtt_routesubscription.h" > + "qmqtt_socketinterface.h" > + "qmqtt_timerinterface.h" > + "qmqtt_message.h"))))) > + (replace 'check > + (lambda* (#:key tests? test-options parallel- + > + #:allow-other-keys) Remove extraneous arguments (test-options, parallel-). > + (when tests? > + (chdir "tests") > + (substitute* "gtest/gtest.pro" > + (("gtest") "")) > + (invoke "qmake"))))))) > + (native-inputs (list googletest perl python)) > + (inputs (list qtbase-5 openssl qtwebsockets)) > + (home-page "https://github.com/alex-spataru/qmqtt") > + (synopsis "MQTT Client") "MQTT client" > + (description "Provides an MQTT Client with SSL support and Websockets.") > + (license license:expat))) Please use make it a full sentence starting with a subject, e.g. "This package provides an MQTT client with [...]". -- Thanks, Maxim