unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: "André Batista" <nandre@riseup.net>
Cc: 61246@debbugs.gnu.org
Subject: [bug#61246] [PATCH v3 2/3] doc: Explain how to use local guix repositories.
Date: Thu, 23 Feb 2023 17:38:45 -0500	[thread overview]
Message-ID: <87y1oogg7e.fsf@gmail.com> (raw)
In-Reply-To: <Y/dfZl37hEHPMNNU@andel> ("André Batista"'s message of "Thu, 23 Feb 2023 09:43:18 -0300")

Hi,

André Batista <nandre@riseup.net> writes:

> Hi Maxim,
>
> sáb 18 fev 2023 às 12:35:32 (1676734532), maxim.cournoyer@gmail.com enviou:
>> (...)
>> >> Perhaps you meant to use @command{git} in the above instead of
>> >> @command{guix}, since it's specific to Git (and the configure snippet is
>> >> for Git) ?
>> >
>> > Not really. It's guix itself and its subcommands which will fail in
>> > this scenario, not git, even though it's because guix is using git
>> > configuration through libgit2. To me it would be misleading to use
>> > @command{git} there. I could come up with a more detailed
>> > description, however, I don't think this would be the place to be
>> > diving on a detailed discussion of guix internals. I'm up to
>> > suggestions though if you think this patch would make people wonder
>> > if it is a typo.
>
> Just to be sure we are on the same page on this: have you followed on
> #55399? AKA Guix has a choice to make here since we could just as
> well decide to diverge from git and disable owner validation checks
> entirely in Guix. On the one side, users wouldn't need to bother with
> git configuration and the manual could do without this patch. On the
> other, would this divergence have any security implications? As far
> as I can see it doesn't, but I may not be seeing far enough and we
> would be hard coding and burying this decision in Guix.
>
> Also we wouldn't be exempting one chosen directory of these checks,
> but disabling it altogether in Guix.

I'm not sure of the security implications this new git switch tries
addressing, so I'd have to read about it more before I can commit on
what's right to do.  In the meantime, we have a recent libgit2 and users
have instructions about dealing with its new security "features", so it
still seems a plus to me.

-- 
Thanks,
Maxim




  reply	other threads:[~2023-02-23 22:39 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-03  3:11 [bug#61246] [PATCH] gnu: libgit2: Update to 1.5.1 André Batista
2023-02-08 15:31 ` Simon Tournier
2023-02-17 19:05   ` [bug#61246] [PATCH v3 0/3] " André Batista
2023-02-17 19:06   ` [bug#61246] [PATCH v3 1/3] gnu: libgit2-1.1: Remove it André Batista
2023-02-17 19:06   ` [bug#61246] [PATCH v3 2/3] doc: Explain how to use local guix repositories André Batista
2023-02-17 19:58     ` Maxim Cournoyer
2023-02-17 23:24       ` André Batista
2023-02-18 17:35         ` Maxim Cournoyer
2023-02-22 18:10           ` André Batista
2023-02-23 21:59             ` bug#61246: " Maxim Cournoyer
2023-02-23 12:43           ` [bug#61246] " André Batista
2023-02-23 22:38             ` Maxim Cournoyer [this message]
2023-02-17 20:45     ` Maxim Cournoyer
2023-02-17 23:31       ` André Batista
2023-02-18 17:43         ` Maxim Cournoyer
2023-02-17 19:07   ` [bug#61246] [PATCH v3 3/3] gnu: libgit2: Update to 1.5.1 André Batista
2023-02-08 15:43 ` [bug#61246] [PATCH v2] " André Batista
2023-02-09  3:25   ` [bug#61246] [PATCH] " Maxim Cournoyer
2023-02-09 12:30     ` zimoun
2023-02-10 17:53     ` André Batista
2023-02-17 19:15       ` André Batista
2023-02-17 19:23         ` André Batista
2023-02-17 19:46         ` Maxim Cournoyer
2023-02-17 23:33           ` André Batista
2023-02-18 18:04           ` Tobias Geerinckx-Rice via Guix-patches via
2023-02-18 18:13             ` Tobias Geerinckx-Rice via Guix-patches via
2023-02-18 20:45               ` Maxim Cournoyer
2023-02-20 10:08                 ` Simon Tournier
2023-02-20 10:05               ` Simon Tournier
2023-02-22 18:17               ` André Batista

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y1oogg7e.fsf@gmail.com \
    --to=maxim.cournoyer@gmail.com \
    --cc=61246@debbugs.gnu.org \
    --cc=nandre@riseup.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).