From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id KBizOI2uHGWI8wAAG6o9tA:P1 (envelope-from ) for ; Wed, 04 Oct 2023 02:15:10 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id KBizOI2uHGWI8wAAG6o9tA (envelope-from ) for ; Wed, 04 Oct 2023 02:15:10 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 879025ABDC for ; Wed, 4 Oct 2023 02:15:09 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=K3Mlw+LL; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1696378509; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=OO5Z7bWZPX4dueYBxkbZFOYnwa+cnZTp9LoVQhOvlAk=; b=Z9v2cxwWzjROGK64yejbZOVlZtAPU8x2JmQzc/ZasAPG8hkwk4NCtb0++gO2SDHHhEBJSb GhWJXVYPy6fhInO0v+ukXPjhVZf1dn4QIGqFhotcBEo+73mZcIxM3SwY5H0Av/Oi0Ip+V2 vkasfvbJWxysse8osZWmPh9l8R1farYAedXeqhV1lYE8HE3zTdwjan9FFKTQudgHecUSdF X3POXx3wkFwTVj9xTqnvO0t6LLJtVqe+r+4Qsi+YA1UEi1kwLEazGc03X03Wux1YSD+Cj8 WJc7L9xaHl+Cj9VprO1EZIqRKlvTpUupXrjg6gN0zpYMYr4jLqMFqJNHJBnCcA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1696378509; a=rsa-sha256; cv=none; b=Z7k+8RUXg6zghtn7YpUD2Lklgn+kDz8cx7FuVdQ4gctHyJRthb+iDKNmmL7dHmu/qq8uzx PkhxRO9kPNt+RsAlHJ4KI5d6VK815atf4BcxoLfEWe6JbGiLbVszPHvBIzzhEAPtx6yvcQ IUvRBjr+r1ebL025orUP1FUMA+h1prTPudbQoY+EBuD7Lds97rtVh4Raq2wDJUJy9VwvE8 9pnckkL/bHVzmInQfYY4McbLPyq0lbCmNuya2BAwF1gh1IQWbGGjcQrDxSBkr8oy91XwOi IINNuXLceCPXnIhdKyOhefIhWUxf9ybzDfg3eQaDi44v2IUWTkY2y4uQDZZiKg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=K3Mlw+LL; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qnpXN-0002Cr-86; Tue, 03 Oct 2023 20:14:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qnpXK-0002Ca-8X for guix-patches@gnu.org; Tue, 03 Oct 2023 20:14:47 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qnpXJ-0002CF-3l for guix-patches@gnu.org; Tue, 03 Oct 2023 20:14:46 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qnpXa-0005IE-5x for guix-patches@gnu.org; Tue, 03 Oct 2023 20:15:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#66199] [PATCH v4 2/2] gnu: librepcb: Update to 1.0.0. Resent-From: pinoaffe Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 04 Oct 2023 00:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66199 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Vinicius Monego Cc: 66199@debbugs.gnu.org Received: via spool by 66199-submit@debbugs.gnu.org id=B66199.169637846520276 (code B ref 66199); Wed, 04 Oct 2023 00:15:02 +0000 Received: (at 66199) by debbugs.gnu.org; 4 Oct 2023 00:14:25 +0000 Received: from localhost ([127.0.0.1]:40948 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qnpWz-0005Gy-A0 for submit@debbugs.gnu.org; Tue, 03 Oct 2023 20:14:25 -0400 Received: from mail-ej1-x634.google.com ([2a00:1450:4864:20::634]:58438) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qnpWw-0005Gi-Dx for 66199@debbugs.gnu.org; Tue, 03 Oct 2023 20:14:23 -0400 Received: by mail-ej1-x634.google.com with SMTP id a640c23a62f3a-9b64b98656bso289821166b.0 for <66199@debbugs.gnu.org>; Tue, 03 Oct 2023 17:14:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696378437; x=1696983237; darn=debbugs.gnu.org; h=mime-version:message-id:in-reply-to:date:subject:cc:to:from :user-agent:references:from:to:cc:subject:date:message-id:reply-to; bh=OO5Z7bWZPX4dueYBxkbZFOYnwa+cnZTp9LoVQhOvlAk=; b=K3Mlw+LLlNWeDctnwy9Bo7i8WErpD86BosOERcLUUpk71UOsMa7q4/LQgGIfivOYw4 M0UI3QIxrJBgpEaXz5J5K53threPgV7pEvTU394Nlo0Vs9TbDtBDq+rQ/q8w4HIRJzY5 O4hecMmCqaPuoa8PjOHgTTWWOVTI9pYVcsXW7IIY14SWVa0XKIuRC40yANTvtUrrf6a0 paOqAWrcIyPOqGD5s7MaKiP6r78SwgFtVZYivW1T3DErsuECwmw4wslkiegxkIzbKwht aKywhkmGwBSnxCCx1f+EMFhosoeA+Aeqo0paBd6WT3XlMQjiOLHXApLF/oBKidNjbK/9 gUeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696378437; x=1696983237; h=mime-version:message-id:in-reply-to:date:subject:cc:to:from :user-agent:references:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=OO5Z7bWZPX4dueYBxkbZFOYnwa+cnZTp9LoVQhOvlAk=; b=IyFQ1qt3BM57etyLipbSNSj199IZWN7TiKtwU5KeBXxm3GJBXJiJ6vNnXpyKWjb3BG TCtAYGBOh8KJyITCqPjjcicsHazNrxbtS9qqJn/zdboqxta9FzU2SWFB8iusZPooVcz+ 9Uzg7szJMI8X8MK2iCRX7eXu7ZpR2Ox8JX9xAFMjOE2qs4BOpm5TL69/BYRCR7Ddop9Y 2CmswsJa4B2giqClcaOdXv3YAZZdNK71i8shVCgfUX9CtOGDQqn9izEYIlp1b+4Eg8gu L/7UPAyHzDvAGDtwCkIZFmUSO8TEwha3iLeYU/Z8QkTJUoidDNP3IiVn8jRvRQjEsPiX l59w== X-Gm-Message-State: AOJu0Yx5ozK07T3CwAlEiXVt2YnLHduEC25yZNlNlRQZpCQx05lsPBYy sNLjU0Qp2BPfWaKa0Dbiwx4= X-Google-Smtp-Source: AGHT+IENpkzWpsPYu/9fb7PPKpckSkusCelUkty8xdQk4/iOB7ak7AT76jhyAbgZk2lUqxJpMk8spQ== X-Received: by 2002:a17:906:1ba1:b0:9ae:5fdc:aee8 with SMTP id r1-20020a1709061ba100b009ae5fdcaee8mr667913ejg.53.1696378437000; Tue, 03 Oct 2023 17:13:57 -0700 (PDT) Received: from localhost (h120217.upc-h.chello.nl. [62.194.120.217]) by smtp.gmail.com with ESMTPSA id w26-20020aa7da5a000000b0052a063e52b8sm1533970eds.83.2023.10.03.17.13.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Oct 2023 17:13:56 -0700 (PDT) References: <01b109c3d00cb4ab5d81d48d22b6bc4cfe0b943a.1695840289.git.pinoaffe@gmail.com> <5d81aa7e-1f82-9089-2d10-1c266c2f6272@posteo.net> User-agent: mu4e 1.10.5; emacs 28.2 From: pinoaffe Date: Wed, 04 Oct 2023 01:39:44 +0200 In-reply-to: <5d81aa7e-1f82-9089-2d10-1c266c2f6272@posteo.net> Message-ID: <87y1gjz1ks.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Spam-Score: 2.75 X-Migadu-Spam-Score: 2.75 X-Migadu-Scanner: mx1.migadu.com X-Migadu-Queue-Id: 879025ABDC X-TUID: NBDY3GmNR4Yz Thanks again! Vinicius Monego writes: >> * gnu/packages/engineering.scm (librepcb): Update to 1.0.0. >> [inputs]: Add various dependencies (both new ones and old ones that are now >> debundled). > > If the change is not automated, then every input should be listed, > separated by commas. Done, I hope this is more or less what you meant >> [arguments]: Remove overriding of configure phase. Replace test >> phase. Debundle various dependencies. > > Avoid words like "various", list all items whenever possible. Okay >> [build-system]: Use cmake-build-system. >> [native-inputs]: Add googletest. > pkg-config was also added to native-inputs. I added it to the commit message > And don't worry too much about the commit message, I can change it > later. Aight >> + (list fontconfig >> + fontobene-qt5 >> + glu >> + hoedown >> + muparser >> + opencascade-occt >> + clipper > Nitpick: 'clipper' is out of order Whoops! >> + `(#:phases (modify-phases %standard-phases >> + (replace 'check >> + (lambda* (#:key tests? #:allow-other-keys) >> + (when tests? >> + (setenv "QT_QPA_PLATFORM" "offscreen") >> + (setenv "QT_QUICK_BACKEND" "software") >> + (display "Running unittests...\n") >> + (invoke "./tests/unittests/librepcb-unittests" "--help"))))) >> + > Why --help? Oops, that's a leftover artifact of me testing some stuff > I ran librepcb-unittests with no arguments and found that > ~20 tests failed out of ~2100. If it's not possible to skip them > manually, you could skip all tests and leave a comment reporting what > happened. I didn't check the output of --help. I manually skipped them, though I feel a bit "dirty" skipping 22 tests without properly knowing why they fail, especially since it's just a constant list of 22 strings in the middle of a package definition. > #:configure-flags is usually placed above #:phases. Okay, I moved it > I think this patch is ready after fixing the test suite. Great! Kind regards, pinoaffe