From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: Efraim Flashner <efraim@flashner.co.il>
Cc: 66576@debbugs.gnu.org, 66553-done@debbugs.gnu.org
Subject: [bug#66576] Request for merging "rust-team" branch
Date: Tue, 17 Oct 2023 11:41:11 -0400 [thread overview]
Message-ID: <87y1g1tfxk.fsf@gmail.com> (raw)
In-Reply-To: <4D6214A4-E59F-4166-B4D0-2CCCE42F5DB4@flashner.co.il> (Efraim Flashner's message of "Mon, 16 Oct 2023 12:30:12 +0000")
Hi Efraim,
Efraim Flashner <efraim@flashner.co.il> writes:
> IMO rust-team branch is ready to merge. We've updated rust to 1.70,
> librsvg to 2.56.4 and many new and updated packages. We've added a phase
> to the cargo-build-system to fail if it detects pre-built files and
> we've set the cargo-build-system to skip the test phase by default,
> allowing us to make sure that the packages have the correct inputs. With
> these changes I've gotten 100% of the packages built using the
> cargo-build-system to build successfully.
This sounds good except I don't understand how disabling the tests by
default help to "make sure that the packages have the correct inputs" ?
You've explained the rationale here:
<https://lists.gnu.org/archive/html/guix-devel/2023-10/msg00182.html>,
saying we sometimes use a newer Rust than the package tests are
expecting; how does it work in the Rust world? Don't they always build
even older versions against the most recent compiler? What about the
test suites then? Are these not typically run by users/distributions?
For one thing the 'guix lint' command would need to be told that
cargo-build-system has #:tests? set to #f by default to not warn without
reasons that '#:tests? #t' is unnecessary.
--
Thanks,
Maxim
next prev parent reply other threads:[~2023-10-17 15:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-16 12:30 [bug#66576] Request for merging "rust-team" branch Efraim Flashner
2023-10-17 15:41 ` Maxim Cournoyer [this message]
[not found] ` <ZS-ZGbsH0gx40DBU@pbp>
2023-10-18 16:57 ` Maxim Cournoyer
[not found] ` <handler.66576.B.169745945630145.ack@debbugs.gnu.org>
2023-10-21 17:41 ` bug#66576: Acknowledgement (Request for merging "rust-team" branch) Efraim Flashner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y1g1tfxk.fsf@gmail.com \
--to=maxim.cournoyer@gmail.com \
--cc=66553-done@debbugs.gnu.org \
--cc=66576@debbugs.gnu.org \
--cc=efraim@flashner.co.il \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).