From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id aI8CAW2QymVBgQAAe85BDQ:P1 (envelope-from ) for ; Mon, 12 Feb 2024 22:41:01 +0100 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id aI8CAW2QymVBgQAAe85BDQ (envelope-from ) for ; Mon, 12 Feb 2024 22:41:01 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=MVcNWoq6; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1707774060; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=x9EK7xv7Fqfdaan68f3JxWOrY5Bwo5XdmQkw5Icrc18=; b=PvBnZ5MYyqpvgwyejiF2SBIhhTuqMmUEafbFy6bGfxJSiDNP07jHNbzUrYz+4Q5gQpPAgT uKU7Y+k3+36eDjIST+Gg1mLZ5sdSIlVcXWxzNYckov3SG464TmVAU/aeUOQxn3n7XFF8h8 qB1bot8dUEDkPzdEYXa7HJprh9Ky+Iv2D34Gu6fyx+ukhdTmHjW0WLfcRrty/md0NNAVcP 7ZAnUXhkqTEvc/TwYQ+2pUs0bvhFoHDaqOStYKTnUC2gbcyQewRJUlocOk7YYwIIiM+hHC KxUU2ETO1YKj9emfxks2caHWnpU8q54S6Xl6M7J1PNwZrA/nsekhZwy0coD+wg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=MVcNWoq6; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Seal: i=1; s=key1; d=yhetil.org; t=1707774060; a=rsa-sha256; cv=none; b=cpHNKHS34qBQq9L087qTLjM5hp44sYll5Mca98RGX6yDSvQJmHg87Q/Aa9+9nUOrQANjm+ HfQFPL35rkC358WPPPACV/Z2Ef79KUt56qyk5nQ11RgOeAa1TX/gZHxbMe0jtfLaZAJ/be mEdbNAaaku1MHkOkw5omk0mNTuJFsxrA4WMgvNkYxR5kfGL3SciNJ/tFhUMCpF7vMk+jOR jbu7dzRGqQuTXvAk7GDahNG+JwSebYgyfoW9gMUSGF5qIlvePs0yRKtN8f3KT1eYquocnO gXtG+d5Qfbk4aaK9bYjox166nRVEaf8a/QJQYGsMJzlt/vwtD5CgQIWn+e07vA== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 9A5285EFEA for ; Mon, 12 Feb 2024 22:41:00 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rZe2j-0004Ax-RD; Mon, 12 Feb 2024 16:40:49 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rZe2g-00044n-90 for guix-patches@gnu.org; Mon, 12 Feb 2024 16:40:46 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rZe2g-0003aZ-0T for guix-patches@gnu.org; Mon, 12 Feb 2024 16:40:46 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rZe2w-00011N-FI for guix-patches@gnu.org; Mon, 12 Feb 2024 16:41:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#68675] [PATCH v2] gnu: Add dhcpcd. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 12 Feb 2024 21:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68675 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: soeren@soeren-tempel.net Cc: 68675@debbugs.gnu.org Received: via spool by 68675-submit@debbugs.gnu.org id=B68675.17077740233711 (code B ref 68675); Mon, 12 Feb 2024 21:41:02 +0000 Received: (at 68675) by debbugs.gnu.org; 12 Feb 2024 21:40:23 +0000 Received: from localhost ([127.0.0.1]:33318 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rZe2I-0000xi-Gh for submit@debbugs.gnu.org; Mon, 12 Feb 2024 16:40:23 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:57592) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rZdvV-0000GO-3H for 68675@debbugs.gnu.org; Mon, 12 Feb 2024 16:33:22 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rZdv7-0002IX-2H; Mon, 12 Feb 2024 16:32:57 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=x9EK7xv7Fqfdaan68f3JxWOrY5Bwo5XdmQkw5Icrc18=; b=MVcNWoq6F0UGm4Ag3YT5 nmJkJ+KTdoGQZurHhiFk8C6CShOvM1aPXdD51xRJXfOOt1mnhsLImHFq76l0UfL0QHFfW3TLfloXj Zjrz7cE6PedW94eOD6RVFeLb+h6jpi+hNBHV36JlDRrRNjVT01VB9UTFa/lA/NtWabD5B2/wyECvA Sl/Wh4a97KtUJo3m4cGrnanuqFoA5yB4Mu7USJNn4oagnFMjdGDOAtl/YuSzwO+qfNGmzgHSLj0Jl EV0WxzJMxuUKXfgXlCvYKQ7lbQoD2G42PhYdxIztIyi0/XkJJpCdZQxCHTcKzwxmj7gxTc78lv2LE umNvEK2FklJjIQ==; From: Ludovic =?UTF-8?Q?Court=C3=A8s?= In-Reply-To: <2156325d2caa8d4298c9828d84fa5fff40592da4.1706123111.git.soeren@soeren-tempel.net> (soeren@soeren-tempel.net's message of "Wed, 24 Jan 2024 20:05:11 +0100") References: <2156325d2caa8d4298c9828d84fa5fff40592da4.1706123111.git.soeren@soeren-tempel.net> Date: Mon, 12 Feb 2024 22:32:52 +0100 Message-ID: <87y1bpbc6z.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -7.17 X-Migadu-Queue-Id: 9A5285EFEA X-Spam-Score: -7.17 X-Migadu-Scanner: mx11.migadu.com X-TUID: 914Z263G6shJ Hi, soeren@soeren-tempel.net skribis: > From: S=C3=B6ren Tempel > > * gnu/packages/admin.scm (dhcpcd): new procedure. > > Signed-off-by: S=C3=B6ren Tempel Overall LGTM modulo minor stylistic issues: > + #:configure-flags #~(list "--enable-ipv6" > + "--enable-privsep" > + "--privsepuser=3Ddhcpcd" > + (string-append "--dbdir=3D" "/var/db/dhc= pcd") > + (string-append "--rundir=3D" "/var/run/d= hcpcd") > + "CC=3Dgcc") Should be (string-append "CC=3D" #$(cc-for-target)). > + (add-before 'build 'setenv > + (lambda _ > + (setenv "HOST_SH" > + (string-append #$bash-minimal "/bin/sh"))= )) Rather (setenv "HOST_SH" (which "sh")). That way users can still override the shell used by the package. > + (add-after 'install 'wrap-hooks > + (lambda* (#:key inputs outputs #:allow-other-keys) > + (let* ((out (assoc-ref outputs "out")) > + (libexec (string-append out "/libexec")) > + (sed (assoc-ref inputs "sed")) > + (coreutils (assoc-ref inputs "coreutils"))) Rather (search-input-file inputs "/bin/sed") and likewise for coreutils, and then=E2=80=A6 > + (wrap-program (string-append libexec > + "/dhcpcd-run-hooks= ") > + `("PATH" ":" suffix > + (,(string-append coreutils "/bin") > + ,(string-append sed "/bin")))))))))) =E2=80=A6 use (dirname sed) and (dirname ls), say, to get their /bin direct= ory. This is more robust than relying on the input label. Ludo=E2=80=99.