From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id oMPUK8jT2GUebQAA62LTzQ:P1 (envelope-from ) for ; Fri, 23 Feb 2024 18:20:08 +0100 Received: from aspmx1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id oMPUK8jT2GUebQAA62LTzQ (envelope-from ) for ; Fri, 23 Feb 2024 18:20:08 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b="CR/Qlhdi"; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1708708808; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=lxo//paOuNYkPAtNk4/irjTUO4yrBqxWb6qDnnN0cB0=; b=YZtlq3ppd7qdp4lfx8D7L0i1wpue+7/VxXi+mYeUDeZeu6Da/52NkPnYi517RROSCfDqdp p4ePMaKeQci6OjLUEj1zvWfFfzQswubg3VvnWX5Pe5K69x1UgmNdcQfZaXCVzfqo4TfBpq 9UZ0LSouvINwYK4rwInE5cAD1j3WRKKx0pxwGzQJaVBIJ/iWH1lb+0rplujug9Pe3dIza2 4uYYAemArarqPq29ZfyS1li3gAE3wSKP2952T7HxHH+k030F2aVkA/HIyNIBiKkWANE+9Z MPAmNOwLYz0bw/QrKH1NnwYfnmEEQYOau5g+wuLznKeT9S3hB8GMFp42Rqy7Lw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b="CR/Qlhdi"; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Seal: i=1; s=key1; d=yhetil.org; t=1708708808; a=rsa-sha256; cv=none; b=Pfay+PA4SJR2uwIVAQPRFyt0F3F7dxxXZ9Db4+r9kk60ribO09neiRwoaNeUWVI0trrTcy JjojtfSjLQtxeXKtJo1EXvJu3VIWPSAeHtW6EN53MzzuE6/g6cOEtnlAk76lCu/jhk6Xob xHnZjlUMY5SMEwz93+stFZylyWEbVXh3sZqGSKEAGxIPJ8maMCqHrBnWeiN87D/JV8jNmU vqX6r3WZ1iWt5sczoCmy6UXzdDNCjowftSdcfuZfpCcByUAyBz0t03LLBLvfInecBOIyUD yDmYQd/K//TgO8dAXCxPDpJjm3HVZ9yj0ktsNhf9ItBRYalLn6Nwzd5cPWvp0w== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 9276D75E08 for ; Fri, 23 Feb 2024 18:20:08 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rdZCK-0002NM-0c; Fri, 23 Feb 2024 12:18:56 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rdYpq-0007gA-7O for guix-patches@gnu.org; Fri, 23 Feb 2024 11:55:43 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rdYpo-0003u5-5E for guix-patches@gnu.org; Fri, 23 Feb 2024 11:55:40 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rdYqA-0005SJ-Bz for guix-patches@gnu.org; Fri, 23 Feb 2024 11:56:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#69291] [PATCH 3/5] scripts: substitute: Replace some leave calls with raise. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 23 Feb 2024 16:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69291 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Christopher Baines Cc: Josselin Poiret , Simon Tournier , Mathieu Othacehe , Tobias Geerinckx-Rice , 69291@debbugs.gnu.org, Ricardo Wurmus , Christopher Baines Received: via spool by 69291-submit@debbugs.gnu.org id=B69291.170870732320851 (code B ref 69291); Fri, 23 Feb 2024 16:56:02 +0000 Received: (at 69291) by debbugs.gnu.org; 23 Feb 2024 16:55:23 +0000 Received: from localhost ([127.0.0.1]:53693 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rdYpT-0005Pr-J9 for submit@debbugs.gnu.org; Fri, 23 Feb 2024 11:55:23 -0500 Received: from eggs.gnu.org ([209.51.188.92]:34142) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rdYbs-0004c2-TK for 69291@debbugs.gnu.org; Fri, 23 Feb 2024 11:41:17 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rdYHV-0005Rq-NP; Fri, 23 Feb 2024 11:20:13 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=lxo//paOuNYkPAtNk4/irjTUO4yrBqxWb6qDnnN0cB0=; b=CR/Qlhdi6vYwtSdvloVU ZGEE6XrwU7tLO2itm9hrNNcTMBgm3z8wpP9E3u502NPWY51X3J1JmdpV21D1uAqY5M99tcpERqOkz f9Qj/Wh+GItrghfq7rd9jreIVhOuQaH2ZoxIeoc56LKJgaBTBjwsDHMxuEopK2RayHALW3+r+jgtl kEJUAqa0jI9JNIdw1fVWr9A40ZFJ7tRiyYfySY3oUwNJoewaQ9I1sBygkwGprCrNy5qIf8PO9a4A6 iSDhJ3XRLnj1m2mSEz9r4hVVd1glMT8e0emYpqcqBZHf7+5otGQqZzUvNkv8HR0d/kt71U8tow14V ZUz9D/5M7ZMBBg==; From: Ludovic =?UTF-8?Q?Court=C3=A8s?= In-Reply-To: <3a88dc8a8369278f86f3a51a99aa62d991ba997d.1708458147.git.mail@cbaines.net> (Christopher Baines's message of "Tue, 20 Feb 2024 19:42:25 +0000") References: <3a88dc8a8369278f86f3a51a99aa62d991ba997d.1708458147.git.mail@cbaines.net> Date: Fri, 23 Feb 2024 17:20:07 +0100 Message-ID: <87y1bbf8zs.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Scanner: mx10.migadu.com X-Migadu-Spam-Score: -1.32 X-Spam-Score: -1.32 X-Migadu-Queue-Id: 9276D75E08 X-TUID: 4ozOlTuwKXqR Christopher Baines skribis: > These calls happen inside of with-error-handling, so the effect should be the > same, but this opens up the possibility of using this code in a program that > doesn't want to exit when one of these error conditions is met. > > Change-Id: I15d963615d85d419559fa0f4333fa4dc1dfbfd3b > > * guix/scripts/substitute.scm (download-nar, process-substitution): Use raise > formatted-message rather than leave. > > Change-Id: Idd0880206b69e3903e19e0536b87d65a52c200d5 LGTM.