From: Suhail Singh <suhailsingh247@gmail.com>
To: Efraim Flashner <efraim@flashner.co.il>
Cc: 69558-done@debbugs.gnu.org, 69557-done@debbugs.gnu.org
Subject: [bug#69557] [bug#69558] [PATCH 0/2] gnu: Add emacs-lsp-booster rust app.
Date: Tue, 05 Mar 2024 10:01:38 -0500 [thread overview]
Message-ID: <87y1awoh7x.fsf@gmail.com> (raw)
In-Reply-To: <ZebWKe-O4THT3Pkt@3900XT> (Efraim Flashner's message of "Tue, 5 Mar 2024 10:22:01 +0200")
Efraim Flashner <efraim@flashner.co.il> writes:
> I had to downgrade rust-clap-verbose-flag-2 from 2.2.0 to 2.1.2
I believe you mean rust-clap-verbosity-flag-2 .
> since 2.2.0 wanted a newer version of clap than we had (and this way I
> could add it straight to master, not to rust-team).
Thank you for doing that and taking the time to respond. Though it does
make me wonder how I was able to build my patch series if it needed a
newer version of clap. Wouldn't the guix build invocation have failed
if that were the case? Perhaps it did fail for you?
Additionally, based on [crates-io] it seems that version 2.2.0 of
clap-verbosity-flag depends on clap version ^4.0.0 and has a
dev-dependency on clap version ^4.4.18. Based on my understanding of
the [caret-syntax] and cargo's treatment of it, it seems that both would
be compatible with the current version of rust-clap-4 in Guix, i.e.,
version 4.4.16. Did I misunderstand something?
[crates-io]:
<https://crates.io/crates/clap-verbosity-flag/2.2.0/dependencies>
[caret-syntax]:
<https://doc.rust-lang.org/cargo/reference/specifying-dependencies.html#caret-requirements>
> I added a comment on emacs-lsp-booster that it was specifically emacs
> and not emacs-minimal.
Yes, that's helpful to make explicit. Good catch.
> Patches pushed!
Thank you!
--
Suhail
next prev parent reply other threads:[~2024-03-05 15:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-04 21:12 [bug#69558] [PATCH 0/2] gnu: Add emacs-lsp-booster rust app Suhail Singh
2024-03-04 23:57 ` [bug#69558] [PATCH 1/2] gnu: Add rust-clap-verbosity-flag-2 Suhail Singh
2024-03-05 5:45 ` [bug#69558] [PATCH 2/2] gnu: Add emacs-lsp-booster Suhail Singh
2024-03-05 8:22 ` [bug#69557] [bug#69558] [PATCH 0/2] gnu: Add emacs-lsp-booster rust app Efraim Flashner
2024-03-05 15:01 ` Suhail Singh [this message]
2024-03-06 7:54 ` Efraim Flashner
2024-03-06 14:59 ` [bug#69557] " Suhail Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y1awoh7x.fsf@gmail.com \
--to=suhailsingh247@gmail.com \
--cc=69557-done@debbugs.gnu.org \
--cc=69558-done@debbugs.gnu.org \
--cc=efraim@flashner.co.il \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).