From: "Ludovic Courtès" <ludo@gnu.org>
To: Benjamin Slade <slade@lambda-y.net>
Cc: 69862-done@debbugs.gnu.org
Subject: bug#69862: [PATCH] update mu to 1.12.2
Date: Fri, 22 Mar 2024 11:42:33 +0100 [thread overview]
Message-ID: <87y1aasg2u.fsf@gnu.org> (raw)
In-Reply-To: <87h6h4epb4.fsf@lambda-y.net> (Benjamin Slade's message of "Sun, 17 Mar 2024 12:33:19 -0500")
Hi,
Benjamin Slade <slade@lambda-y.net> skribis:
>>From eeaea275fab5141dad07ed01614018a5eb8e0511 Mon Sep 17 00:00:00 2001
> From: Benjamin Slade <slade@lambda-y.net>
> Date: Sun, 17 Mar 2024 10:33:02 -0500
> Subject: [PATCH] update mu to 1.12.2
>
I added a commit log that follows our conventions and applied it.
> (add-after 'unpack 'patch-bin-references
> (lambda _
> (substitute* '("guile/tests/test-mu-guile.cc"
> - "mu/tests/test-mu-cmd.cc"
> - "mu/tests/test-mu-cmd-cfind.cc"
> "mu/tests/test-mu-query.cc")
> (("/bin/sh") (which "sh")))
> (substitute* '("lib/tests/bench-indexer.cc"
> "lib/utils/mu-test-utils.cc")
> - (("/bin/rm") (which "rm")))))
> + (("/bin/rm") (which "rm")))
> + (substitute* '("lib/mu-maildir.cc")
> + (("/bin/mv") (which "mv")))))
This won’t do the right thing when cross-compiling. To fix it, it
should be changed to things like:
(search-input-file inputs "/bin/mv")
The problem predates this patch of course so it’s not a blocker, but
something to look at going forward.
Thanks,
Ludo’.
prev parent reply other threads:[~2024-03-22 10:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-17 17:33 [bug#69862] [PATCH] update mu to 1.12.2 Benjamin Slade
2024-03-22 10:42 ` Ludovic Courtès [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y1aasg2u.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=69862-done@debbugs.gnu.org \
--cc=slade@lambda-y.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).