unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Christopher Baines <mail@cbaines.net>
To: Dale Mellor <guix-devel-0brg6a@rdmp.org>
Cc: 69613-done@debbugs.gnu.org, goodoldpaul@autistici.org
Subject: bug#69613: [PATCH v2] gnu: Add ssh-to-pgp.
Date: Tue, 23 Apr 2024 14:55:12 +0100	[thread overview]
Message-ID: <87y194yyin.fsf@cbaines.net> (raw)
In-Reply-To: <20240421024302.733484-1-guix-devel-0brg6a@rdmp.org> (Dale Mellor's message of "Sun, 21 Apr 2024 03:43:02 +0100")

[-- Attachment #1: Type: text/plain, Size: 749 bytes --]

Dale Mellor <guix-devel-0brg6a@rdmp.org> writes:

> From: Giacomo Leidi <goodoldpaul@autistici.org>
>
> * gnu/packages/crypto.scm (ssh-to-pgp): New variable.
>
> Review:
>   * License is MIT declared as expat, fine
>   * Standard declaration for a Go package
>   * guix lint, build --check, build --source --check, all run clean
>   * I had a very cursory look over the upstream source, nothing nasty
>       jumps out
>   * It works for me
>
> Reviewed-by: Dale Mellor <guix-devel-0brg6a@rdmp.org>
> Change-Id: Ic8e55ede6b19d9a90291e3ac2cf608e8a59bc061
> ---
>  gnu/packages/crypto.scm | 27 +++++++++++++++++++++++++++
>  1 file changed, 27 insertions(+)

Thanks both, I've pushed this to master as
0d1070a5e294235f2ba821e2cda04d682ec9202a.

Chris

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 987 bytes --]

      reply	other threads:[~2024-04-23 13:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-07 14:36 [bug#69613] [PATCH] gnu: Add ssh-to-pgp Giacomo Leidi via Guix-patches via
2024-04-21  2:43 ` [bug#69613] [PATCH v2] " Dale Mellor
2024-04-23 13:55   ` Christopher Baines [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y194yyin.fsf@cbaines.net \
    --to=mail@cbaines.net \
    --cc=69613-done@debbugs.gnu.org \
    --cc=goodoldpaul@autistici.org \
    --cc=guix-devel-0brg6a@rdmp.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).