[bug#71204] [PATCH 1/2] gnu: guix: Add imagemagick, perl and use full graphviz.

[bug#71204] [PATCH 1/2] gnu: guix: Add imagemagick, perl and use full graphviz.

[Maxim Cournoyer]

This makes it possible to run 'make distcheck' in a 'guix shell -D guix'
environment.

* gnu/packages/package-management.scm (guix)
[native-inputs]: Replace graphviz-minimal with graphviz.  Add imagemagick and
perl.

Change-Id: Ie400c622d8fc77108df29c03e11f36159d6f6238
---
 gnu/packages/package-management.scm | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/package-management.scm b/gnu/packages/package-management.scm
index 862de9f942..2f1434d5be 100644
--- a/gnu/packages/package-management.scm
+++ b/gnu/packages/package-management.scm
@@ -490,8 +490,10 @@ (define-public guix
                        ("automake" ,automake)
                        ("gettext" ,gettext-minimal)
                        ("texinfo" ,texinfo)
-                       ("graphviz" ,graphviz-minimal)
+                       ("graphviz" ,graphviz) ;non-minimal for PDF support
                        ("font-ghostscript" ,font-ghostscript) ;fonts for 'dot'
+                       ("imagemagick" ,imagemagick) ;for 'make dist'
+                       ("perl" ,perl)               ;for 'make dist'
                        ("help2man" ,help2man)
                        ("po4a" ,po4a-minimal)))
       (inputs

base-commit: 77771036f0970083c146b709d792d128f4235125
-- 
2.41.0

[bug#71204] [PATCH 1/2] gnu: guix: Add imagemagick, perl and use full graphviz.

[Zheng Junjie]

[-- Attachment #1: Type: text/plain, Size: 1493 bytes --]

Maxim Cournoyer <maxim.cournoyer@gmail.com> writes:

> This makes it possible to run 'make distcheck' in a 'guix shell -D guix'

I think maybe should add them to manifest.scm? And just 'guix shell' or
'guix shell -m manifest.scm'?


> environment.
>
> * gnu/packages/package-management.scm (guix)
> [native-inputs]: Replace graphviz-minimal with graphviz.  Add imagemagick and
> perl.
>
> Change-Id: Ie400c622d8fc77108df29c03e11f36159d6f6238
> ---
>  gnu/packages/package-management.scm | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/package-management.scm b/gnu/packages/package-management.scm
> index 862de9f942..2f1434d5be 100644
> --- a/gnu/packages/package-management.scm
> +++ b/gnu/packages/package-management.scm
> @@ -490,8 +490,10 @@ (define-public guix
>                         ("automake" ,automake)
>                         ("gettext" ,gettext-minimal)
>                         ("texinfo" ,texinfo)
> -                       ("graphviz" ,graphviz-minimal)
> +                       ("graphviz" ,graphviz) ;non-minimal for PDF support
>                         ("font-ghostscript" ,font-ghostscript) ;fonts for 'dot'
> +                       ("imagemagick" ,imagemagick) ;for 'make dist'
> +                       ("perl" ,perl)               ;for 'make dist'
>                         ("help2man" ,help2man)
>                         ("po4a" ,po4a-minimal)))
>        (inputs
>
> base-commit: 77771036f0970083c146b709d792d128f4235125

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

[bug#71204] [PATCH 1/2] gnu: guix: Add imagemagick, perl and use full graphviz.

[Maxim Cournoyer]

Hi Zheng,

Zheng Junjie <zhengjunjie@iscas.ac.cn> writes:

> Maxim Cournoyer <maxim.cournoyer@gmail.com> writes:
>
>> This makes it possible to run 'make distcheck' in a 'guix shell -D guix'

> I think maybe should add them to manifest.scm? And just 'guix shell' or
> 'guix shell -m manifest.scm'?

I think it's nice that 'make distcheck' works out of the box, even for
'guix shell -D guix ...'.  According to 'guix size' the
new $GUIX_ENVIRONMENT produced with the added inputs do not add any
weight, so were probably already transitively referenced.

Also see PATCH 2/2 where I augment the manifest.scm file with
git:send-email and friends.

-- 
Thanks,
Maxim

[bug#71204] [PATCH 1/2] gnu: guix: Add imagemagick, perl and use full graphviz.

[Zheng Junjie]

[-- Attachment #1: Type: text/plain, Size: 758 bytes --]

Maxim Cournoyer <maxim.cournoyer@gmail.com> writes:

> Hi Zheng,
>
> Zheng Junjie <zhengjunjie@iscas.ac.cn> writes:
>
>> Maxim Cournoyer <maxim.cournoyer@gmail.com> writes:
>>
>>> This makes it possible to run 'make distcheck' in a 'guix shell -D guix'
>
>> I think maybe should add them to manifest.scm? And just 'guix shell' or
>> 'guix shell -m manifest.scm'?
>
> I think it's nice that 'make distcheck' works out of the box, even for
> 'guix shell -D guix ...'.  According to 'guix size' the
> new $GUIX_ENVIRONMENT produced with the added inputs do not add any

ok, LGTM. 

> weight, so were probably already transitively referenced.
>
> Also see PATCH 2/2 where I augment the manifest.scm file with
> git:send-email and friends.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

bug#71204: [PATCH 1/2] gnu: guix: Add imagemagick, perl and use full graphviz.

[Maxim Cournoyer]

Hi,

Zheng Junjie <zhengjunjie@iscas.ac.cn> writes:

> Maxim Cournoyer <maxim.cournoyer@gmail.com> writes:
>
>> Hi Zheng,
>>
>> Zheng Junjie <zhengjunjie@iscas.ac.cn> writes:
>>
>>> Maxim Cournoyer <maxim.cournoyer@gmail.com> writes:
>>>
>>>> This makes it possible to run 'make distcheck' in a 'guix shell -D guix'
>>
>>> I think maybe should add them to manifest.scm? And just 'guix shell' or
>>> 'guix shell -m manifest.scm'?
>>
>> I think it's nice that 'make distcheck' works out of the box, even for
>> 'guix shell -D guix ...'.  According to 'guix size' the
>> new $GUIX_ENVIRONMENT produced with the added inputs do not add any
>
> ok, LGTM. 

Applied, thanks for taking a look!

-- 
Thanks,
Maxim