unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#71228] [PATCH] gnu: guile-ncurses unicode fix
@ 2024-05-27 15:34 tmarjeski
  2024-06-02  8:18 ` tmarjeski
  2024-07-11 10:43 ` bug#71228: " Ludovic Courtès
  0 siblings, 2 replies; 3+ messages in thread
From: tmarjeski @ 2024-05-27 15:34 UTC (permalink / raw)
  To: 71228

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: patch file --]
[-- Type: text/x-patch, Size: 1361 bytes --]

From 10c8622694ce0c6141b5a827e4ffddcd47f9d4b8 Mon Sep 17 00:00:00 2001
From: Trevor Arjeski <tmarjeski@gmail.com>
Date: Mon, 27 May 2024 18:22:33 +0300
Subject: [PATCH] gnu: guile-ncurses: fix configure-flags for unicode build

The flag "--with-ncursesw" doesn't seem to exist for guile-ncurses, and it
seemed to cause the build to not include unicode support. Building without it
produces the expected "with ncursesw" support.

This can be checked within the guile REPL using:
> ,use (ncurses curses)
> %wide-ncurses
> #t ; has unicode and wide char support
---
 gnu/packages/guile-xyz.scm | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/gnu/packages/guile-xyz.scm b/gnu/packages/guile-xyz.scm
index 44b4118e0a..8276380fc3 100644
--- a/gnu/packages/guile-xyz.scm
+++ b/gnu/packages/guile-xyz.scm
@@ -2718,8 +2718,7 @@ (define-public guile-ncurses
                   (guix build utils))
        #:imported-modules ((guix build guile-build-system)
                            ,@%gnu-build-system-modules)
-       #:configure-flags (list "--with-ncursesw" ; Unicode support
-                               "--with-gnu-filesystem-hierarchy")
+       #:configure-flags (list "--with-gnu-filesystem-hierarchy")
        #:phases
        (modify-phases %standard-phases
          (add-before 'build 'fix-libguile-ncurses-file-name
-- 
2.45.1





^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [bug#71228] [PATCH] gnu: guile-ncurses unicode fix
  2024-05-27 15:34 [bug#71228] [PATCH] gnu: guile-ncurses unicode fix tmarjeski
@ 2024-06-02  8:18 ` tmarjeski
  2024-07-11 10:43 ` bug#71228: " Ludovic Courtès
  1 sibling, 0 replies; 3+ messages in thread
From: tmarjeski @ 2024-06-02  8:18 UTC (permalink / raw)
  To: 71228; +Cc: zimon.toutoune, paren, ludo, me, rekado, jgart, othacehe, guix

Hi folks,
I recieved an email about someone else wanting this change and was
wondering if it could be looked at.

Thanks!




^ permalink raw reply	[flat|nested] 3+ messages in thread

* bug#71228: [PATCH] gnu: guile-ncurses unicode fix
  2024-05-27 15:34 [bug#71228] [PATCH] gnu: guile-ncurses unicode fix tmarjeski
  2024-06-02  8:18 ` tmarjeski
@ 2024-07-11 10:43 ` Ludovic Courtès
  1 sibling, 0 replies; 3+ messages in thread
From: Ludovic Courtès @ 2024-07-11 10:43 UTC (permalink / raw)
  To: tmarjeski; +Cc: 71228-done

Hi,

tmarjeski@gmail.com skribis:

>>From 10c8622694ce0c6141b5a827e4ffddcd47f9d4b8 Mon Sep 17 00:00:00 2001
> From: Trevor Arjeski <tmarjeski@gmail.com>
> Date: Mon, 27 May 2024 18:22:33 +0300
> Subject: [PATCH] gnu: guile-ncurses: fix configure-flags for unicode build
>
> The flag "--with-ncursesw" doesn't seem to exist for guile-ncurses, and it
> seemed to cause the build to not include unicode support. Building without it
> produces the expected "with ncursesw" support.
>
> This can be checked within the guile REPL using:
>> ,use (ncurses curses)
>> %wide-ncurses
>> #t ; has unicode and wide char support

I tweaked the commit log to match our conventions and finally applied
it, thank you!

Ludo’.




^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-07-11 10:47 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-05-27 15:34 [bug#71228] [PATCH] gnu: guile-ncurses unicode fix tmarjeski
2024-06-02  8:18 ` tmarjeski
2024-07-11 10:43 ` bug#71228: " Ludovic Courtès

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).