unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou via Guix-patches via <guix-patches@gnu.org>
To: Nicolas Goaziou via Guix-patches via <guix-patches@gnu.org>
Cc: Thanos Apollo <public@thanosapollo.org>, 71460-done@debbugs.gnu.org
Subject: bug#71460: Fixing commit message
Date: Wed, 19 Jun 2024 09:56:14 +0200	[thread overview]
Message-ID: <87y1715psx.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <87r0d4wyfy.fsf@nicolasgoaziou.fr> (Nicolas Goaziou via Guix-patches via's message of "Mon, 10 Jun 2024 18:32:33 +0200")

Nicolas Goaziou via Guix-patches via <guix-patches@gnu.org> writes:

> Thanos Apollo <public@thanosapollo.org> writes:

>> * gnu/packages/emacs-xyz.scm (emacs-yeetube): Update to 2.1.6.
>
> You need to add that you removed wget dependency:
>
>   [arguments]<#:phases>: No longer replace (executable-find "wget") in
>   the code base.
>   [inputs]: Remove WGET.
>

[...]

>>  (define-public emacs-yeetube
>> -  (let ((commit "c74e4e77156297624d278a05bdd19c016a91ff9b")) ;version bump
>> +  (let ((commit "c9721a295f4fd30a44e94b3424151fa8a14d22ae"))
>
> Why are you removing the comment? It is used to indicate that upstream
> does not tag commits, but this commit matches the version bump anyway.

I applied the changes and push the commit.

Regards,






      reply	other threads:[~2024-06-19  7:57 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-09 21:11 [bug#71460] [PATCH] gnu: emacs-yeetube: Update to 2.1.16 Thanos Apollo
2024-06-10 15:26 ` [bug#71460] Fixing commit message Thanos Apollo
2024-06-10 16:32   ` Nicolas Goaziou via Guix-patches via
2024-06-19  7:56     ` Nicolas Goaziou via Guix-patches via [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y1715psx.fsf@nicolasgoaziou.fr \
    --to=guix-patches@gnu.org \
    --cc=71460-done@debbugs.gnu.org \
    --cc=mail@nicolasgoaziou.fr \
    --cc=public@thanosapollo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).