From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: Liliana Marie Prikler <liliana.prikler@gmail.com>
Cc: vivien@planete-kraus.eu, 73128@debbugs.gnu.org
Subject: [bug#73128] [PATCH gnome-team 07/12] gnu: Add libei.
Date: Wed, 11 Sep 2024 14:47:55 +0900 [thread overview]
Message-ID: <87y13y3fn8.fsf@gmail.com> (raw)
In-Reply-To: <b4a74c9ed2d3a3e93efeac660debdf252b9bd61c.1725829379.git.liliana.prikler@gmail.com> (Liliana Marie Prikler's message of "Sun, 8 Sep 2024 20:47:15 +0200")
Hi,
Liliana Marie Prikler <liliana.prikler@gmail.com> writes:
> * gnu/packages/freedesktop.scm (libei): New variable.
>
> Co-authored-by: Vivien Kraus <vivien@planete-kraus.eu>
[...]
> +(define-public libei
> + (package
> + (name "libei")
> + (version "1.3.0")
> + (source (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url "https://gitlab.freedesktop.org/libinput/libei.git")
> + (commit version)))
> + (sha256
> + (base32
> + "0idbl20ax060s7m435rszfv7c0bvpinjvq45qbqwvcvp0hg8r9y8"))
> + (snippet
> + #~(begin
> + (use-modules (guix build utils))
> + (substitute* "test/meson.build"
> + (("subproject\\('munit'")
> + "# subproject('munit'")
> + ((", fallback: \\['munit', 'munit_dep'\\]")
> + ""))
> + (delete-file-recursively "subprojects")))))
What is the above snippet for? A comment would be great.
> + (build-system meson-build-system)
> + (arguments
> + (list
> + #:configure-flags #~'("-Ddocumentation=api" ;protocol requires hugo
> + "-Dsd-bus-provider=libelogind")))
> + (inputs
> + (list elogind libevdev libxkbcommon))
> + (propagated-inputs
> + ;; liboeffis-1.0.pc requires.private libelogind
> + (list elogind))
> + (native-inputs
> + (list doxygen libxml2 munit pkg-config python python-attrs python-black python-dbusmock python-jinja2 python-pytest python-structlog valgrind/interactive))
160 chars is a tad long for our 80 columns maximum width convention :-).
> + (home-page "https://libinput.pages.freedesktop.org/libei/")
> + (synopsis "Emulated Input protocol implementation")
> + (description
> + "Libei provides a client and server implementation of the @acronym{EI,Emulated
I think you can safely add a space after the comma, for extra
readability (and allowing M-q to break tE long line).
Otherwise, LGTM.
--
Thanks,
Maxim
next prev parent reply other threads:[~2024-09-11 5:50 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-08 21:02 [bug#73128] [PATCH gnome-team 00/12] Mini update dump Liliana Marie Prikler
2024-09-08 14:32 ` [bug#73128] [PATCH gnome-team 01/12] gnu: orca: Update to 46.2 Liliana Marie Prikler
2024-09-08 14:36 ` [bug#73128] [PATCH gnome-team 02/12] gnu: gnome-music: Update to 46.0 Liliana Marie Prikler
2024-09-08 15:01 ` [bug#73128] [PATCH gnome-team 03/12] gnu: gnome-session: " Liliana Marie Prikler
2024-09-11 5:49 ` Maxim Cournoyer
2024-09-11 17:03 ` Liliana Marie Prikler
2024-09-12 0:58 ` Maxim Cournoyer
2024-09-08 15:10 ` [bug#73128] [PATCH gnome-team 04/12] gnu: gnome-control-center: Update to 46.3 Liliana Marie Prikler
2024-09-08 18:47 ` [bug#73128] [PATCH gnome-team 07/12] gnu: Add libei Liliana Marie Prikler
2024-09-11 5:47 ` Maxim Cournoyer [this message]
2024-09-08 18:51 ` [bug#73128] [PATCH gnome-team 09/12] gnu: xdg-desktop-portal-gnome: Update to 46.2 Liliana Marie Prikler
2024-09-08 20:21 ` [bug#73128] [PATCH gnome-team 11/12] gnu: mutter: Update to 46.4 Liliana Marie Prikler
2024-09-08 20:22 ` [bug#73128] [PATCH gnome-team 10/12] gnu: sysprof: Propagate libdex Liliana Marie Prikler
2024-09-08 20:28 ` [bug#73128] [PATCH gnome-team 12/12] gnu: gnome-remote-desktop: Update to 46.3 Liliana Marie Prikler
2024-09-08 21:02 ` [bug#73128] [PATCH gnome-team 06/12] gnu: Add munit Vivien Kraus
2024-09-11 5:33 ` Maxim Cournoyer
2024-09-08 21:02 ` [bug#73128] [PATCH gnome-team 08/12] gnu: xdg-desktop-portal: Update to 1.18.4 dan
2024-09-11 5:52 ` Maxim Cournoyer
2024-09-11 5:11 ` [bug#73128] [PATCH gnome-team 00/12] Mini update dump Maxim Cournoyer
2024-09-11 17:00 ` Liliana Marie Prikler
2024-09-12 0:57 ` Maxim Cournoyer
2024-09-11 6:00 ` Maxim Cournoyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y13y3fn8.fsf@gmail.com \
--to=maxim.cournoyer@gmail.com \
--cc=73128@debbugs.gnu.org \
--cc=liliana.prikler@gmail.com \
--cc=vivien@planete-kraus.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).