unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#75121] [PATCH] gnu: Add emacs-lucid.
@ 2024-12-26 18:20 Divya Ranjan via Guix-patches via
  2024-12-27  8:47 ` [bug#75121] QA review for 75121 Cayetano Santos via Guix-patches via
  0 siblings, 1 reply; 4+ messages in thread
From: Divya Ranjan via Guix-patches via @ 2024-12-26 18:20 UTC (permalink / raw)
  To: 75121; +Cc: Divya Ranjan

* gnu/packages/emacs.scm (emacs-lucid): New variable.
---
 gnu/packages/emacs.scm | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index c5b57211dd..1628bde99c 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -525,6 +525,21 @@ (define-public emacs-pgtk-xwidgets
      (modify-inputs (package-inputs emacs-pgtk)
        (prepend gsettings-desktop-schemas webkitgtk-with-libsoup2)))))
 
+(define-public emacs-lucid
+  (package/inherit emacs-no-x
+    (name "emacs-lucid")
+    (synopsis
+     "The extensible, customizable, self-documenting text editor (with Lucid toolkit)")
+    (inputs (modify-inputs (package-inputs emacs)
+              (delete gtk+)
+              (prepend libxaw)))
+    (arguments
+     (substitute-keyword-arguments
+         (package-arguments emacs-no-x)
+       ((#:configure-flags flags #~'())
+        #~(cons "--with-x-toolkit=lucid"
+                #$flags))))))
+
 (define-public emacs-motif
   (package/inherit emacs-no-x
     (name "emacs-motif")
-- 
2.46.0





^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [bug#75121] QA review for 75121
  2024-12-26 18:20 [bug#75121] [PATCH] gnu: Add emacs-lucid Divya Ranjan via Guix-patches via
@ 2024-12-27  8:47 ` Cayetano Santos via Guix-patches via
  2025-01-01 15:21   ` Divya Ranjan via Guix-patches via
  0 siblings, 1 reply; 4+ messages in thread
From: Cayetano Santos via Guix-patches via @ 2024-12-27  8:47 UTC (permalink / raw)
  To: control, 75121

[-- Attachment #1: Type: text/plain, Size: 389 bytes --]


user guix
usertag 75121 + waiting-on-contributor
thanks

Guix QA review form submission:

- Synopsys line is too long
- use "gtk+" for coherence with equivalent packages

Other than this, the package builds, I’m using it right now, thanks !

--
Cayetano Santos
GnuPG Key:   https://meta.sr.ht/~csantosb.pgp
FingerPrint: CCB8 1842 F9D7 058E CD67 377A BF5C DF4D F6BF 6682

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 259 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [bug#75121] QA review for 75121
  2024-12-27  8:47 ` [bug#75121] QA review for 75121 Cayetano Santos via Guix-patches via
@ 2025-01-01 15:21   ` Divya Ranjan via Guix-patches via
  2025-01-02  7:55     ` Cayetano Santos via Guix-patches via
  0 siblings, 1 reply; 4+ messages in thread
From: Divya Ranjan via Guix-patches via @ 2025-01-01 15:21 UTC (permalink / raw)
  To: 75121; +Cc: control, csantosb

[-- Attachment #1: Type: text/plain, Size: 270 bytes --]

Hello Cayetano,

Fixed the indenting, find the formatted patch in the attachment.

> - use "gtk+" for coherence with equivalent packages

I don’t know what’s to do with this though, I’m just removing the gtk+ dependency since we just need libxaw.

Regards,

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-Add-emacs-lucid.patch --]
[-- Type: text/x-patch, Size: 1308 bytes --]

From 7ef73062e137cb5945daafa32c20b8f3d5bae4ec Mon Sep 17 00:00:00 2001
From: Divya Ranjan <divya@subvertising.org>
Date: Wed, 1 Jan 2025 15:15:37 +0000
Subject: [PATCH] gnu: Add emacs-lucid.

* gnu/packages/emacs.scm (emacs-lucid): New variable.
---
 gnu/packages/emacs.scm | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index c5b57211dd..4ac69527c5 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -525,6 +525,21 @@ (define-public emacs-pgtk-xwidgets
      (modify-inputs (package-inputs emacs-pgtk)
        (prepend gsettings-desktop-schemas webkitgtk-with-libsoup2)))))
 
+(define-public emacs-lucid
+  (package/inherit emacs-no-x
+    (name "emacs-lucid")
+    (synopsis
+     "The extensible, customizable, self-documenting text editor
+(with Lucid toolkit)")
+    (inputs (modify-inputs (package-inputs emacs)
+              (delete gtk+)
+              (prepend libxaw)))
+    (arguments (substitute-keyword-arguments (package-arguments emacs-no-x)
+                 ((#:configure-flags flags
+                   #~'())
+                  #~(cons "--with-x-toolkit=lucid"
+                          #$flags))))))
+
 (define-public emacs-motif
   (package/inherit emacs-no-x
     (name "emacs-motif")
-- 
2.47.1


[-- Attachment #3: Type: text/plain, Size: 60 bytes --]


-- 
Divya Ranjan,
Philosophy, Mathematics, Libre Software.

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [bug#75121] QA review for 75121
  2025-01-01 15:21   ` Divya Ranjan via Guix-patches via
@ 2025-01-02  7:55     ` Cayetano Santos via Guix-patches via
  0 siblings, 0 replies; 4+ messages in thread
From: Cayetano Santos via Guix-patches via @ 2025-01-02  7:55 UTC (permalink / raw)
  To: Divya Ranjan; +Cc: control, 75121

[-- Attachment #1: Type: text/plain, Size: 659 bytes --]


user guix
usertag 75121 - waiting-on-contributor
usertag 75121 - reviewed-looks-good
thanks

>mer. 01 janv. 2025 at 15:21, Divya Ranjan <divya@subvertising.org> wrote:

> Hello Cayetano,
>
> Fixed the indenting, find the formatted patch in the attachment.
>
>> - use "gtk+" for coherence with equivalent packages
>
> I don’t know what’s to do with this though, I’m just removing the gtk+ dependency since we
> just need libxaw.
>
> Regards,
>
> [2. text/x-patch; 0001-gnu-Add-emacs-lucid.patch]...

--
Cayetano Santos
GnuPG Key:   https://meta.sr.ht/~csantosb.pgp
FingerPrint: CCB8 1842 F9D7 058E CD67 377A BF5C DF4D F6BF 6682

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 259 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2025-01-02  7:56 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-12-26 18:20 [bug#75121] [PATCH] gnu: Add emacs-lucid Divya Ranjan via Guix-patches via
2024-12-27  8:47 ` [bug#75121] QA review for 75121 Cayetano Santos via Guix-patches via
2025-01-01 15:21   ` Divya Ranjan via Guix-patches via
2025-01-02  7:55     ` Cayetano Santos via Guix-patches via

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).