From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59750) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d9IUk-0003G0-F9 for guix-patches@gnu.org; Fri, 12 May 2017 17:53:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d9IUg-000734-Ev for guix-patches@gnu.org; Fri, 12 May 2017 17:53:06 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:38713) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1d9IUg-00072q-C0 for guix-patches@gnu.org; Fri, 12 May 2017 17:53:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1d9IUg-0004Wk-2h for guix-patches@gnu.org; Fri, 12 May 2017 17:53:02 -0400 Subject: bug#26840: [PATCH 2/3] gnu: go-1.4: Add missing module imports. Resent-Message-ID: From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) References: <20170508195549.23372-1-slyfox@inbox.ru> <20170508195549.23372-3-slyfox@inbox.ru> <87poffi2tn.fsf@openmailbox.org> Date: Fri, 12 May 2017 23:52:02 +0200 In-Reply-To: <87poffi2tn.fsf@openmailbox.org> (Kei Kebreau's message of "Thu, 11 May 2017 15:57:40 -0400") Message-ID: <87wp9l68vx.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Kei Kebreau Cc: 26840@debbugs.gnu.org Hi Kei, Kei Kebreau skribis: > Sergei Trofimovich writes: > >> * gnu/packages/golang.scm (go-1.4): Add missing modules to >> %modify-phases call: srfi-1 >> --- >> gnu/packages/golang.scm | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm >> index 00630ce06..d19aa65af 100644 >> --- a/gnu/packages/golang.scm >> +++ b/gnu/packages/golang.scm >> @@ -62,7 +62,8 @@ >> (arguments >> `(#:modules ((ice-9 match) >> (guix build gnu-build-system) >> - (guix build utils)) >> + (guix build utils) >> + (srfi srfi-1)) >> #:tests? #f ; Tests are run by the all.bash script. >> #:phases >> (modify-phases %standard-phases > > */me looks at git log and facepalms* > > Never mind my other email... I see that the reason these are already on > master is because they were already pushed there. Feel free to close > these! Though as discussed in another thread with Sergei, it=E2=80=99s not entirely clear to me that these #:modules patches should be committed (and they are for =E2=80=98core-updates=E2=80=99, not =E2=80=98master=E2=80=99.) I would rather see whether we can find a more generic solution to this problem before patching every single instance. How does that sound? Ludo=E2=80=99.