From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46230)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dDdr6-0007gd-GN
	for guix-patches@gnu.org; Wed, 24 May 2017 17:30:09 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dDdr1-00042r-JB
	for guix-patches@gnu.org; Wed, 24 May 2017 17:30:08 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:34003)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1dDdr1-00042h-Go
	for guix-patches@gnu.org; Wed, 24 May 2017 17:30:03 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dDdr1-0000Ob-Av
	for guix-patches@gnu.org; Wed, 24 May 2017 17:30:03 -0400
Subject: bug#27018: [PATCH 1/5] gnu: Allow overriding of xgcc package in
	cross-gcc.
Resent-To: guix-patches@gnu.org
Resent-Message-ID: <handler.27018.D27018.14956613581439.done@debbugs.gnu.org>
References: <20170522135531.3787-1-rekado@elephly.net>
	<20170522141319.2410-1-rekado@elephly.net>
	<20170524191943.514b6ac6@scratchpost.org>
From: Ricardo Wurmus <rekado@elephly.net>
In-reply-to: <20170524191943.514b6ac6@scratchpost.org>
Date: Wed, 24 May 2017 23:29:02 +0200
Message-ID: <87wp96ueox.fsf@elephly.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Danny Milosavljevic <dannym@scratchpost.org>
Cc: 27018-done@debbugs.gnu.org


Danny Milosavljevic <dannym@scratchpost.org> writes:

> Hi Ricardo,
>
> On Mon, 22 May 2017 16:13:15 +0200
> Ricardo Wurmus <rekado@elephly.net> wrote:
>
>>  (define* (cross-gcc target
>> -                    #:optional (xbinutils (cross-binutils target)) libc)
>> +                    #:key
>> +                    (xgcc %xgcc)
>> +                    (xbinutils (cross-binutils target))
>> +                    (libc #f))
>
> Why is it "xgcc", "xbinutils", but "libc" (no "x")? Aren't they all the "cross" versions?

I don’t really know, but I assumed that it is because the libc is not a
set of cross-build tools but a library.

Anyway, thanks for the review.  I’m going to push this now.

--
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
https://elephly.net