From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47320) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dxf8G-0003r1-JR for guix-patches@gnu.org; Thu, 28 Sep 2017 16:10:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dxf8F-0001wv-HV for guix-patches@gnu.org; Thu, 28 Sep 2017 16:10:04 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:56727) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dxf8F-0001we-EB for guix-patches@gnu.org; Thu, 28 Sep 2017 16:10:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dxf8F-0004Rl-8Y for guix-patches@gnu.org; Thu, 28 Sep 2017 16:10:03 -0400 Subject: [bug#28423] gnu: Add imb-openmpi. Resent-Message-ID: From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) References: <877ex5j7dz.fsf@albion.it.manchester.ac.uk> <87377tj72w.fsf@albion.it.manchester.ac.uk> <877ex4ysk1.fsf@gnu.org> Date: Thu, 28 Sep 2017 22:09:45 +0200 In-Reply-To: <877ex4ysk1.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Tue, 12 Sep 2017 15:06:54 +0200") Message-ID: <87wp4ik2k6.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Dave Love Cc: 28423@debbugs.gnu.org Ping! :-) ludo@gnu.org (Ludovic Court=C3=A8s) skribis: > Heya, > > Dave Love skribis: > >> From eed7aaac597248505d0ad0609810f7af5caac720 Mon Sep 17 00:00:00 2001 >> From: Dave Love >> Date: Sat, 9 Sep 2017 11:10:29 +0100 >> Subject: [PATCH] gnu: Add imb-openmpi. >> >> * mpi.scm (gnu, imb): New function. >> (imb-openmpi): New package. > > [...] > >> + (inputs >> + `((,(package-name mpi) ,mpi))) > > Rather: > > `(("mpi" ,mpi)) > >> + (replace 'build >> + (lambda* _ >> + (let ((mpi-home (dirname (dirname (which "mpicc"))))) > > I'd suggest: > > (lambda* (#:key inputs #:allow-other-keys) > (let ((mpi (assoc-ref inputs "mpi"))) > ...)) > >> + (zero? >> + ;; Not safe for parallel build >> + (system >> + (format #f "make -C imb/src -f make_mpich SHELL=3Dsh M= PI_HOME=3D~a" >> + mpi-home)))))) > > Rather use =E2=80=98system*=E2=80=99 to avoid going through the shell. > >> + (system >> + (string-append >> + "cd imb/src && install -m755 IMB-IO IMB-EXT IMB-MPI1= IMB-NBC IMB-RMA " >> + bin))) >> + (zero? >> + (system >> + (string-append >> + "cd imb && cp -r license " doc)))))))))) > > Likewise, use =E2=80=98copy-file=E2=80=99 and =E2=80=98copy-recursively= =E2=80=99 rather than shelling > out. > >> + (synopsis (format #f "Intel MPI Benchmarks, ~a version" (package-na= me mpi))) >> + (description (format #f "\ >> +A set of MPI performance measurements for point-to-point and global >> +communication, and file, operations for a range of message sizes. >> +The generated benchmark data fully characterize: >> +@itemize >> +@item >> +Performance of a cluster system, including node performance, network la= tency, >> +and throughput; >> +@item >> +Efficiency of the MPI implementation. >> +@end itemize >> +This is the ~a version." (package-name mpi))) > > Please avoid constructing synopsis/description strings as this prevents > i18n. > > My suggestion would be to either leave them unchanged, which should be > good enough anyway, or to just modify the synopsis but then arrange to > have the whole string translated. > > Could you send an updated patch? > > Thanks, > Ludo=E2=80=99.