From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36574)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1e7qql-0007bJ-B6
	for guix-patches@gnu.org; Thu, 26 Oct 2017 18:42:08 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1e7qqg-0005B8-De
	for guix-patches@gnu.org; Thu, 26 Oct 2017 18:42:07 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:55252)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1e7qqg-0005Ay-AF
	for guix-patches@gnu.org; Thu, 26 Oct 2017 18:42:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1e7qqg-0001Je-39
	for guix-patches@gnu.org; Thu, 26 Oct 2017 18:42:02 -0400
Subject: [bug#29017] [PATCH] gnu: Add gwl.
Resent-Message-ID: <handler.29017.B29017.15090577105035@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <87h8ulhbun.fsf@gnu.org>
Date: Thu, 26 Oct 2017 15:41:42 -0700
In-Reply-To: <87h8ulhbun.fsf@gnu.org> (Roel Janssen's message of "Thu, 26 Oct
	2017 22:51:12 +0200")
Message-ID: <87wp3hcz15.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Roel Janssen <roel@gnu.org>
Cc: 29017@debbugs.gnu.org

Hello!

Roel Janssen <roel@gnu.org> skribis:

> I would like to add GWL.  For a lack of a better place, I chose the
> bioinformatics module because that's where we use this package.

Awesome!  \o/

Perhaps that could go to package-management.scm?

> From eaa22755769973ba30600ae96bb92a5d6bad11dd Mon Sep 17 00:00:00 2001
> From: Roel Janssen <roel@gnu.org>
> Date: Thu, 26 Oct 2017 22:46:50 +0200
> Subject: [PATCH] gnu: Add gwl.
>
> * gnu/packages/bioinformatics.scm (gwl): New variable.

[...]

> +(define-public gwl
> +  (package
> +    (name "gwl")
> +    (version "0.1.0")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append "https://git.roelj.com/attachments/"
> +                                  "d804e310-b9c0-44b1-bd18-c7505e9f9d9b"=
))

Do you have a more =E2=80=9Cstandard=E2=80=9D URL, such as a cgit snapshot?=
  If not
that=E2=80=99s fine.

> +    (inputs
> +     `(("guix" ,guix)
> +       ("guile" ,guile-2.2)
> +       ("guile-commonmark" ,guile-commonmark)))

It might be that you either need to propagate Guix and CommonMark, or to
wrap the binaries that GWL provides (as is done in the =E2=80=98guix=E2=80=
=99 package),
no?

Otherwise LGTM, thank you!

Ludo=E2=80=99.