From: ludo@gnu.org (Ludovic Courtès)
To: Leo Famulari <leo@famulari.name>
Cc: 29299@debbugs.gnu.org
Subject: [bug#29299] [PATCH] build-system/go: Don't let Go executables refer to the Go compiler.
Date: Thu, 16 Nov 2017 11:50:23 +0100 [thread overview]
Message-ID: <87wp2qfqfk.fsf@gnu.org> (raw)
In-Reply-To: <20171114204817.GA9307@jasmine.lan> (Leo Famulari's message of "Tue, 14 Nov 2017 15:48:17 -0500")
Heya,
Leo Famulari <leo@famulari.name> skribis:
> On Tue, Nov 14, 2017 at 01:57:38PM -0500, Leo Famulari wrote:
>> On Tue, Nov 14, 2017 at 12:00:36PM -0500, Leo Famulari wrote:
>> > This is a naive adaptation of ((guix build utils)
>> > remove-store-references).
>> >
>> > It takes ~55 seconds to remove the references from Syncthing's
>> > executables (96 MiB) on an SSD. Any ideas about how to speed it up?
>>
>> I checked, and remove-store-references (aka nuke-refs) takes the same
>> amount of time.
>
> So, fold-port-matches reads the port one character at a time, IIUC (I
> don't really understand it).
>
> I think we don't need to do that in this case. We could instead do
> Boyer-Moore and skip 34 bytes + the length of %store-directory, which
> could speed things up a lot.
Indeed. Mark’s code in (guix build grafts) does this, perhaps that
would be a better source of inspiration.
But yeah, no need to wait for that optimization. :-)
Ludo’.
next prev parent reply other threads:[~2017-11-16 10:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-14 17:00 [bug#29299] [PATCH] build-system/go: Don't let Go executables refer to the Go compiler Leo Famulari
2017-11-14 18:57 ` Leo Famulari
2017-11-14 20:48 ` Leo Famulari
2017-11-16 10:50 ` Ludovic Courtès [this message]
2017-11-16 10:52 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wp2qfqfk.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=29299@debbugs.gnu.org \
--cc=leo@famulari.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).