From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55851) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1egtwj-0006p3-4f for guix-patches@gnu.org; Wed, 31 Jan 2018 10:05:18 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1egtwd-00008r-7V for guix-patches@gnu.org; Wed, 31 Jan 2018 10:05:09 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:43479) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1egtwd-00008Y-0d for guix-patches@gnu.org; Wed, 31 Jan 2018 10:05:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1egtwc-00058v-34 for guix-patches@gnu.org; Wed, 31 Jan 2018 10:05:02 -0500 Subject: [bug#29678] [PATCH] gnu: qemu: Add pulseaudio support. Resent-Message-ID: From: Marius Bakke In-Reply-To: <87y3kexfb4.fsf@gmail.com> References: <87o9n3kgez.fsf@gmail.com> <87608qd964.fsf@fastmail.com> <87y3kexfb4.fsf@gmail.com> Date: Wed, 31 Jan 2018 16:04:54 +0100 Message-ID: <87wozyoyqx.fsf@fastmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Oleg Pykhalov Cc: 29678@debbugs.gnu.org --=-=-= Content-Type: text/plain Oleg Pykhalov writes: >>> #:phases >>> (modify-phases %standard-phases >>> (replace 'configure >>> @@ -166,6 +171,7 @@ >>> ("ncurses" ,ncurses) >>> ;; ("pciutils" ,pciutils) >>> ("pixman" ,pixman) >>> + ("pulseaudio" ,pulseaudio) >> >> I see pulseaudio is already in Qemus closure, > > How do you see this? > > Is that what do you use? > --8<---------------cut here---------------start------------->8--- > guix graph --type=references pulseaudio | dot -Tsvg > pulseaudio.svg > --8<---------------cut here---------------end--------------->8--- I used `guix size qemu | grep pulseaudio`. However "qemu-minimal" does not include pulseaudio, which increases the size by about 25%. Can you drop the input from qemu-minimal at the same time? Unfortunately we might have to override #:configure-flags as well. [...] > @@ -96,10 +97,13 @@ > '(;; Running tests in parallel can occasionally lead to failures, like: > ;; boot_sector_test: assertion failed (signature == SIGNATURE): (0x00000000 == 0x0000dead) > #:parallel-tests? #f > - #:configure-flags (list "--enable-usb-redir" "--enable-opengl" > - (string-append "--smbd=" > - (assoc-ref %outputs "out") > - "/libexec/samba-wrapper")) > + #:configure-flags > + (list "--enable-usb-redir" > + "--enable-opengl" > + (string-append "--smbd=" (assoc-ref %outputs "out") > + "/libexec/samba-wrapper") > + (string-append "--audio-drv-list=" > + (string-join (list "alsa" "pa" "sdl") ","))) Nit-pick: I don't really see the benefit of using string-join here. But no strong opinion. However: use '() instead of (list ...) when the elements do not need to be evaluated. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlpx2xYACgkQoqBt8qM6 VPqXAQf+KkXekXL0/Kx/Mjb9cgJpEVQvivqlFvPW07cJKyeckZDy0iPxQp+6twE9 o59bFNhwhXF9TZEMpZIOvueQUn26pBzPzq3dwgYEYqF0kyJuCHeYrAjtcmkbNAPA ieD2usOVd8x0oeEbYYjHGsMYW83qgVMZK91AWKNmcJTWjTkfzePnr9Ct63BqFpnN ZVmQirLp6FqHqh8Y4g24+fQoCrme7umqs2AmOVLHSPYOMt8MCWiZwEXs0syrHefb QBUrz10IR+1FoRbWCG3fSyODeMctiKOtzQ5yzm9yDQp4NFZtEn3MlIj5mdH6fQ+X di2tz745dy+Em3rzCefghyuwj4pRJA== =k701 -----END PGP SIGNATURE----- --=-=-=--