From: Oleg Pykhalov <go.wigust@gmail.com>
To: Marius Bakke <mbakke@fastmail.com>
Cc: 30495@debbugs.gnu.org
Subject: [bug#30495] [PATCH] bash completion: Complete files names after 'guix package -m'.
Date: Sat, 17 Feb 2018 19:03:11 +0300 [thread overview]
Message-ID: <87wozbtxhc.fsf@gmail.com> (raw)
In-Reply-To: <87wozbtyah.fsf@fastmail.com> (Marius Bakke's message of "Sat, 17 Feb 2018 16:45:42 +0100")
[-- Attachment #1.1: Type: text/plain, Size: 1261 bytes --]
Marius Bakke <mbakke@fastmail.com> writes:
> Oleg Pykhalov <go.wigust@gmail.com> writes:
>
>> * etc/completion/bash/guix (_guix_is_dash_L): Replace with
>> ‘_guix_is_dash_L_or_m’.
>> (_guix_complete): Add this.
>
> [...]
>
>> diff --git a/etc/completion/bash/guix b/etc/completion/bash/guix
>> index 6b84193db..286c4f1c5 100644
>> --- a/etc/completion/bash/guix
>> +++ b/etc/completion/bash/guix
>> @@ -97,9 +97,10 @@ _guix_is_removing ()
>> $result
>> }
>>
>> -_guix_is_dash_L ()
>> +_guix_is_dash_L_or_m ()
>> {
>> - [ "${COMP_WORDS[$COMP_CWORD - 1]}" = "-L" ] \
>> + comp_words_minus_1="${COMP_WORDS[$COMP_CWORD - 1]}"
>> + [ "$comp_words_minus_1" = "-L" ] || [ "$comp_words_minus_1" = "-m" ] \
>> || { case "${COMP_WORDS[$COMP_CWORD]}" in
>> --load-path=*) true;;
>> *) false;;
>
> I think this fails to account for the long form "--manifest". Perhaps
> it's better to add a new "_guix_is_dash_m" and use
>
> "if _guix_is_dash_L || _guix_is_dash_m"
>
> below. WDYT?
Nice catch! Thanks.
But I don't know how to implement a file completion for ‘--manifest=’.
‘--load-path=’ doesn't have a file completion too. Only completion for
equal sign before.
Oleg.
[-- Attachment #1.2: [PATCH] bash completion: Complete files names after 'guix package --]
[-- Type: text/x-patch, Size: 1285 bytes --]
From b6d104ec1b3df46a409c989bf12e19c30a920c00 Mon Sep 17 00:00:00 2001
From: Oleg Pykhalov <go.wigust@gmail.com>
Date: Sat, 17 Feb 2018 12:05:26 +0300
Subject: [PATCH] bash completion: Complete files names after 'guix package
-m'.
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
* etc/completion/bash/guix (_guix_is_dash_L): Replace with
‘_guix_is_dash_L_or_m’.
(_guix_complete): Add this.
---
etc/completion/bash/guix | 11 ++++++++++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/etc/completion/bash/guix b/etc/completion/bash/guix
index 6b84193db..70430c5c9 100644
--- a/etc/completion/bash/guix
+++ b/etc/completion/bash/guix
@@ -106,6 +106,15 @@ _guix_is_dash_L ()
esac }
}
+_guix_is_dash_m ()
+{
+ [ "${COMP_WORDS[$COMP_CWORD - 1]}" = "-m" ] \
+ || { case "${COMP_WORDS[$COMP_CWORD]}" in
+ --manifest=*) true;;
+ *) false;;
+ esac }
+}
+
_guix_complete_file ()
{
# Let Readline complete file names.
@@ -149,7 +158,7 @@ _guix_complete ()
*)
if _guix_is_command "package"
then
- if _guix_is_dash_L
+ if _guix_is_dash_L || _guix_is_dash_m
then
_guix_complete_file
elif _guix_is_removing
--
2.16.1
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
next prev parent reply other threads:[~2018-02-17 16:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-17 9:07 [bug#30495] [PATCH] bash completion: Complete files names after 'guix package -m' Oleg Pykhalov
2018-02-17 15:45 ` Marius Bakke
2018-02-17 16:03 ` Oleg Pykhalov [this message]
2018-02-17 16:14 ` Marius Bakke
2018-02-17 19:25 ` bug#30495: " Oleg Pykhalov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wozbtxhc.fsf@gmail.com \
--to=go.wigust@gmail.com \
--cc=30495@debbugs.gnu.org \
--cc=mbakke@fastmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).