From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44309)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1esF0g-0002eM-2o
	for guix-patches@gnu.org; Sat, 03 Mar 2018 16:48:07 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1esF0c-0004f6-UG
	for guix-patches@gnu.org; Sat, 03 Mar 2018 16:48:06 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:35299)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1esF0c-0004eu-Pe
	for guix-patches@gnu.org; Sat, 03 Mar 2018 16:48:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1esF0c-0006OM-HQ
	for guix-patches@gnu.org; Sat, 03 Mar 2018 16:48:02 -0500
Subject: [bug#30570] [PATCH 13/16] gnu: Add google-brotli.
Resent-Message-ID: <handler.30570.B30570.152011367424557@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <7597f2a5e819b04be0bd24566b4fcd7950abb5c1.1519241713.git.leo@famulari.name>
	<7597f2a5e819b04be0bd24566b4fcd7950abb5c1.1519241713.git.leo@famulari.name>
	<9b91d15c1eeba4563d162e8f223f0d93b624bfa3.1519241713.git.leo@famulari.name>
Date: Sat, 03 Mar 2018 22:47:49 +0100
In-Reply-To: <9b91d15c1eeba4563d162e8f223f0d93b624bfa3.1519241713.git.leo@famulari.name>
	(Leo Famulari's message of "Wed, 21 Feb 2018 14:35:17 -0500")
Message-ID: <87woys6dbu.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Leo Famulari <leo@famulari.name>
Cc: 30570@debbugs.gnu.org

Leo Famulari <leo@famulari.name> skribis:

> * gnu/packages/compression.scm (google-brotli): New variable.

[...]

> +         (add-after 'install 'rename-static-libraries
> +           ;; The build tools put a 'static' suffix on the static libraries, but
> +           ;; other applications don't know how to find these.
> +           (let ((lib (string-append (assoc-ref %outputs "out") "/lib/")))
> +             (lambda _

Rather: (lambda (#:key outputs #:allow-other-keys)
          (let ((lib (string-append (assoc-ref outputs "out") "/lib/")))
            ...))

> +    (home-page "https://github.com/google/brotli")
> +    (synopsis "General-purpose lossless compression")
> +    (description "This package provides the reference implementation of Brotli,
> +a generic-purpose lossless compression algorithm that compresses data using a
> +combination of a modern variant of the LZ77 algorithm, Huffman coding and 2nd
> +order context modeling, with a compression ratio comparable to the best
> +currently available general-purpose compression methods. It is similar in speed
                                                           ^
Missing space.  :-)

Otherwise LGTM.