[bug#30744] [PATCH] tests: mail: Add test for dovecot.

["Clément Lassieur" <clement@lassieur.org>]

Oleg Pykhalov <go.wigust@gmail.com> writes:

> Hello Clément,
>
> Clément Lassieur <clement@lassieur.org> writes:
>
>> Oleg Pykhalov <go.wigust@gmail.com> writes:
>
> […]
>
>>> +          ;; Give the service time to start talking.
>>> +          (wait-for-file "/var/run/dovecot/master.pid" marionette)
>>
>> Could you put it in a test context (test-assert with file-exists? for
>> example, see tests/messaging.scm)?
>
> OK.
>
> I replaced ‘(wait-for-file …)’ and a comment with:
> --8<---------------cut here---------------start------------->8---
> ;; Check Dovecot service's PID.
> (test-assert "service process id"
>   (let ((pid
>          (number->string (wait-for-file "/var/run/dovecot/master.pid"
>                                         marionette))))
>     (marionette-eval `(file-exists? (string-append "/proc/" ,pid))
>                      marionette)))
> --8<---------------cut here---------------end--------------->8---

Cool, thank you!

> […]
>
>>> +                  (match (scandir TESTBOX/new)
>>> +                    ((cwd .. message-file)
>>
>> You need to use double quotes, like ("." ".." message-file) I believe.
>
> It works.  Thank you!
>
> […]
>
> I think it's ready for a push to ‘origin/master’.  WDYT?

Sure, you can push to master :-)