From: "Clément Lassieur" <clement@lassieur.org>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 31089-done@debbugs.gnu.org
Subject: bug#31089: [PATCH 3/5] services: cgit: Add support for file-like objects.
Date: Wed, 11 Apr 2018 21:27:14 +0200 [thread overview]
Message-ID: <87woxd8rxp.fsf@lassieur.org> (raw)
In-Reply-To: <87woxei1iw.fsf@lassieur.org>
Clément Lassieur <clement@lassieur.org> writes:
> Ludovic Courtès <ludo@gnu.org> writes:
>
>>> (config-str
>>> (if opaque-config?
>>> (opaque-cgit-configuration-cgitrc config)
>>> - (with-output-to-string
>>> - (lambda ()
>>> - (serialize-configuration config
>>> - cgit-configuration-fields))))))
>>> + (serialize-configuration config cgit-configuration-fields))))
>>> #~(begin
>>> (use-modules (guix build utils))
>>> (mkdir-p #$(if opaque-config?
>>> (opaque-cgit-configuration-cache-root config)
>>> (cgit-configuration-cache-root config)))
>>> - (copy-file #$(plain-file "cgitrc" config-str) "/etc/cgitrc"))))
>>> + (copy-file #$(mixed-text-file "cgitrc" config-str)
>>> + "/etc/cgitrc"))))
>>
>> For clarity, since ‘config-str’ is no longer a string (right?), I’d
>> rename it to just ‘config’ or something.
>>
>> Also, could it be that you’re missing ‘apply’ above, as in:
>>
>> (apply mixed-text-file "cgitrc" config-str)
>>
>> ?
>
> Yes, config-str is still a string (or a string-valued gexp). I use
> mixed-text-file because it can take gexps as arguments, whereas
> plain-file can't.
>
>> Otherwise LGTM, thanks!
>
> Thank you for the review!
>
> Clément
Pushed.
next prev parent reply other threads:[~2018-04-11 19:28 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-07 17:04 [bug#31089] cgit service: add support for file-like objects Clément Lassieur
2018-04-07 17:07 ` [bug#31089] [PATCH 1/5] services: cgit: Simplify 'uglify-field-name' Clément Lassieur
2018-04-07 17:07 ` [bug#31089] [PATCH 2/5] services: cgit: Simplify 'serialize-module-link-path' Clément Lassieur
2018-04-10 20:56 ` Ludovic Courtès
2018-04-07 17:07 ` [bug#31089] [PATCH 3/5] services: cgit: Add support for file-like objects Clément Lassieur
2018-04-09 7:19 ` Clément Lassieur
2018-04-10 20:59 ` Ludovic Courtès
2018-04-11 8:35 ` Clément Lassieur
2018-04-11 19:27 ` Clément Lassieur [this message]
2018-04-07 17:07 ` [bug#31089] [PATCH 4/5] services: cgit: Enforce serialization order Clément Lassieur
2018-04-10 21:00 ` Ludovic Courtès
2018-04-07 17:07 ` [bug#31089] [PATCH 5/5] services: cgit: Add support for project-list Clément Lassieur
2018-04-10 21:00 ` Ludovic Courtès
2018-04-10 20:56 ` [bug#31089] [PATCH 1/5] services: cgit: Simplify 'uglify-field-name' Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87woxd8rxp.fsf@lassieur.org \
--to=clement@lassieur.org \
--cc=31089-done@debbugs.gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).