From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52731)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fdNKB-0007aL-Nv
	for guix-patches@gnu.org; Wed, 11 Jul 2018 18:11:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fdNKB-0005GX-11
	for guix-patches@gnu.org; Wed, 11 Jul 2018 18:11:03 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:48141)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1fdNKA-0005GN-TU
	for guix-patches@gnu.org; Wed, 11 Jul 2018 18:11:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fdNKA-0007YV-Nk
	for guix-patches@gnu.org; Wed, 11 Jul 2018 18:11:02 -0400
Subject: [bug#32117] [PATCH 1/2] store: Add `binary-file'.
Resent-Message-ID: <handler.32117.B32117.153134701328976@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
In-Reply-To: <20180710174128.6360-2-janneke@gnu.org> (Jan Nieuwenhuizen's
	message of "Tue, 10 Jul 2018 19:41:27 +0200")
References: <20180710174128.6360-1-janneke@gnu.org>
	<20180710174128.6360-2-janneke@gnu.org>
Date: Thu, 12 Jul 2018 00:09:54 +0200
Message-ID: <87wou1h1al.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Jan Nieuwenhuizen <janneke@gnu.org>
Cc: 32116@debbugs.gnu.org, 32117@debbugs.gnu.org

Hello,

Jan Nieuwenhuizen <janneke@gnu.org> skribis:

> * guix/store.scm (binary-file): New function.
> * doc/guix.texi (G-Expressions): Describe binary-file*.

[...]

> +@deffn {Monadic Procedure} binary-file* @var{name} @var{data} @dots{}

There=E2=80=99s no =E2=80=98*=E2=80=99 in the actual procedure name.

Also, could you move this @deffn to =E2=80=9CThe Store Monad=E2=80=9D, righ=
t after
=E2=80=98text-file=E2=80=99?

Apart from that it LGTM, thanks!

Ludo=E2=80=99.