From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53056)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1g7HJb-000194-Oq
	for guix-patches@gnu.org; Tue, 02 Oct 2018 05:50:05 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1g7HJa-0004Pb-Hd
	for guix-patches@gnu.org; Tue, 02 Oct 2018 05:50:03 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:57765)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1g7HJa-0004OI-D9
	for guix-patches@gnu.org; Tue, 02 Oct 2018 05:50:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1g7HJZ-0002pP-Te
	for guix-patches@gnu.org; Tue, 02 Oct 2018 05:50:01 -0400
Subject: [bug#32727] [PATCH] gnu: Add telegram-purple.
Resent-Message-ID: <handler.32727.B32727.153847374710790@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <20180913114958.14496-1-sleep_walker@gnu.org>
	<20180913122056.21012-1-sleep_walker@gnu.org>
	<20180916005815.GA4866@jasmine.lan>
Date: Tue, 02 Oct 2018 11:48:51 +0200
In-Reply-To: <20180916005815.GA4866@jasmine.lan> (Leo Famulari's message of
	"Sat, 15 Sep 2018 20:58:15 -0400")
Message-ID: <87wor0r858.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Leo Famulari <leo@famulari.name>
Cc: 32727@debbugs.gnu.org

Hello!

Tom=C3=A1=C5=A1, did you have a chance to look into this?

Thanks,
Ludo=E2=80=99.

Leo Famulari <leo@famulari.name> skribis:

> On Thu, Sep 13, 2018 at 02:20:56PM +0200, Tom=C3=A1=C5=A1 =C4=8Cech wrote:
>> +    (source (origin
>> +              (method git-fetch)
>> +              (uri (git-reference
>> +                    (url "https://github.com/majn/telegram-purple")
>> +                    (commit (string-append "v" version))
>> +                    (recursive? #t)))
>
> This recursive Git clone brings brings two libraries with it, 'tgl' and
> 'tl-parser':
>
> https://github.com/majn/tgl/
> https://github.com/vysheng/tl-parser
>
> Is it possible to include these as their own separate Guix packages?
> Would anything else potentially use them?
>
> In general we try to avoid bundling things, but sometimes the effort is
> not worth it.
>
>> +     `(#:tests? #f
>
> If there are no tests, please add a comment like "No test suite". Or
> else leave a comment explaining why we skip the tests.
>
>> +         (add-after 'unpack 'prepare-commit.h
>> +           (lambda _
>> +             (with-output-to-file "./commit.h"
>> +               (lambda ()
>> +                 (display
>> +                  (string-append "//generated by guix, use version inst=
ead of "
>> +                                 "commit\n"
>> +                                 "#ifndef GIT_COMMIT\n"
>> +                                 "#  define GIT_COMMIT \"v"
>> +                                 ,version "\"\n"
>> +                                 "#endif\n"))))))
>
> Can you add a brief comment explaining this?
>
>> +    (description "Telegram protocol support for pidgin.")
>
> To make it a complete sentence, how about ""Telegram-purple is a Libpurple
> protocol plugin that adds support for the Telegram messenger."?