unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Oleg Pykhalov <go.wigust@gmail.com>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 33466@debbugs.gnu.org, 33466-done@debbugs.gnu.org
Subject: bug#33466: [PATCH 2/2] repl: Add 'colorized' and 'readline' support.
Date: Mon, 03 Dec 2018 08:07:07 +0300	[thread overview]
Message-ID: <87woorqjus.fsf@gmail.com> (raw)
In-Reply-To: <87y397ltg7.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Sun, 02 Dec 2018 18:38:48 +0100")

[-- Attachment #1: Type: text/plain, Size: 923 bytes --]

ludo@gnu.org (Ludovic Courtès) writes:

> Oleg Pykhalov <go.wigust@gmail.com> skribis:
>
>> From 95b95b24107084baf03e9635280a8c3136b2a356 Mon Sep 17 00:00:00 2001
>> From: Oleg Pykhalov <go.wigust@gmail.com>
>> Date: Thu, 22 Nov 2018 17:24:04 +0300
>> Subject: [PATCH] repl: Load user's initialization file.
>>
>> * guix/scripts/repl.scm (guix-repl): Load user's initialization file.
>
> [...]
>
>>                  (set-current-module user-module)
>> +                (when (file-exists? %guile-initialization-file)
>> +                      (load %guile-initialization-file))
>
> Rather:
>
>   (and=> (getenv "HOME")
>          (lambda (home)
>            (when (file-exists? …)
>              …)))
>
> Otherwise if HOME is undefined simply loading (guix scripts repl) will
> cause an error.

Ah, I see.  Thank you.

Pushed as 37c6f11f8dfa1880db86a3510c9e50990304d76c

Thanks,
Oleg.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

  reply	other threads:[~2018-12-03  5:08 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-22 14:40 [bug#33466] [PATCH 0/2] Improve guix repl Oleg Pykhalov
2018-11-22 14:42 ` [bug#33466] [PATCH 1/2] repl: Do not exit repl on SIGINT Oleg Pykhalov
2018-11-22 14:42   ` [bug#33466] [PATCH 2/2] repl: Add 'colorized' and 'readline' support Oleg Pykhalov
2018-11-25 20:40     ` Ludovic Courtès
2018-12-01 20:48       ` Oleg Pykhalov
2018-12-02 17:38         ` Ludovic Courtès
2018-12-03  5:07           ` Oleg Pykhalov [this message]
2018-11-25 20:39   ` [bug#33466] [PATCH 1/2] repl: Do not exit repl on SIGINT Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87woorqjus.fsf@gmail.com \
    --to=go.wigust@gmail.com \
    --cc=33466-done@debbugs.gnu.org \
    --cc=33466@debbugs.gnu.org \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).