From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57553) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gZvzn-0004s1-AL for guix-patches@gnu.org; Thu, 20 Dec 2018 05:56:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gZvzm-0006hB-Jq for guix-patches@gnu.org; Thu, 20 Dec 2018 05:56:03 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:51237) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gZvzm-0006gz-EV for guix-patches@gnu.org; Thu, 20 Dec 2018 05:56:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gZvzm-00041E-Ab for guix-patches@gnu.org; Thu, 20 Dec 2018 05:56:02 -0500 Subject: [bug#33801] import: github: Support source URIs that redirect to GitHub Resent-Message-ID: From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <87d0pxtciz.fsf@gnu.org> Date: Thu, 20 Dec 2018 11:55:36 +0100 In-Reply-To: (Arun Isaac's message of "Thu, 20 Dec 2018 12:26:26 +0530") Message-ID: <87woo4qxg7.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Arun Isaac Cc: 33801@debbugs.gnu.org Hi, Arun Isaac skribis: >> Do you know how many packages fall into that category? > > With this patch, we have a problem estimating the coverage using `guix > refresh -L'. Now, to estimate coverage, we need to make HTTP requests > for every single source tarball in Guix to determine if it redirects to > GitHub. This is an enormous number of HTTP requests! When I ran `guix > refresh -L', it took a very long time to finish coverage estimation. So, > I cancelled the command. Any better way to handle this? Ouch, that=E2=80=99s a problem indeed. We could maintain a cache of redire= cts, although that wouldn=E2=80=99t be a real solution. Hmm, now that I think about it, shouldn=E2=80=99t we store the github.com U= RL directly for these packages? We could add a new lint check along the lines of the =E2=80=98check-mirror-url=E2=80=99 procedure that would allow = us to find out which URLs need to be changed. If we took that route, the changes you made to the importer would no longer be necessary. :-/ WDYT? Thanks, Ludo=E2=80=99.