From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:40264) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gmx9m-0002Hp-GT for guix-patches@gnu.org; Fri, 25 Jan 2019 03:48:11 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gmx4q-0005MB-DD for guix-patches@gnu.org; Fri, 25 Jan 2019 03:43:06 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:45215) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gmx4o-0005LI-HD for guix-patches@gnu.org; Fri, 25 Jan 2019 03:43:04 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gmx4o-0007UT-3u for guix-patches@gnu.org; Fri, 25 Jan 2019 03:43:02 -0500 Subject: [bug#34154] [PATCH] /etc/os-release Resent-Message-ID: From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20190121101740.GB11658@macbook41> <87y37cjruq.fsf@gnu.org> <20190123072017.GA6135@macbook41> <87h8dzheyp.fsf@gnu.org> <87h8dz7gg5.fsf@elephly.net> <20190123143203.3yqtklffr3twr35i@uptimegirl.lan> Date: Fri, 25 Jan 2019 09:42:06 +0100 In-Reply-To: <20190123143203.3yqtklffr3twr35i@uptimegirl.lan> (ng0's message of "Wed, 23 Jan 2019 14:32:03 +0000") Message-ID: <87womtruw1.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: ng0@n0.is Cc: 34154@debbugs.gnu.org Hello, ng0@n0.is skribis: > Ricardo Wurmus transcribed 722 bytes: >>=20 >> Ludovic Court=C3=A8s writes: >>=20 >> >> It looks like some build systems can try to get information from it >> >> during building if they have distro-specific things to do. >> > >> > That is precisely the kind of bad practice that I=E2=80=99d rather not >> > encourage. :-) >>=20 >> Build systems doing this is bad, of course, but if this was a script >> that tried to be helpful by telling the user what commands to run to >> install dependencies I think it could be helpful. >>=20 >> (I have a vague memory of a project that tried to figure out how to >> detect if the script is running on a Guix system by checking for >> /run/current-system and the like.) > > It was PyBitmessage. > https://github.com/Bitmessage/PyBitmessage/commit/b7e75b9bc51e7036045167a= d6191fe339f1a9daa#diff-2eeaed663bd0d25b7e608891384b7298 > Later on they realized this was a terrible idea. > Maybe we could have a documentation section for 'best practices' > to recommend against trying to detect Guix(SD) like this or > rather provide positive examples? It's not our job, but people > can get confused as PyBitmessage showed. Interesting example. I=E2=80=99d argue that PyBitmessage is going too far = by trying to guess that commands the user should do=E2=80=94it=E2=80=99s bound= to provide inaccurate or outdated instructions at some point. Anyway, I=E2=80=99m not strongly opposed to adding this file, but I think it would help to have a couple of compelling examples. :-) Thanks, Ludo=E2=80=99.