From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([209.51.188.92]:53317)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gnoaG-0006wJ-JL
	for guix-patches@gnu.org; Sun, 27 Jan 2019 12:51:05 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gnoaF-0005kT-N3
	for guix-patches@gnu.org; Sun, 27 Jan 2019 12:51:04 -0500
Received: from debbugs.gnu.org ([209.51.188.43]:48618)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1gnoaF-0005kK-B7
	for guix-patches@gnu.org; Sun, 27 Jan 2019 12:51:03 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gnoaD-0004sZ-Sn
	for guix-patches@gnu.org; Sun, 27 Jan 2019 12:51:03 -0500
Subject: [bug#34222] [PATCH 08/15] gnu: Add ruby-rest-client.
Resent-Message-ID: <handler.34222.B34222.154861140318680@debbugs.gnu.org>
References: <87y376ghl0.fsf@cbaines.net>
	<20190127170820.28937-1-mail@cbaines.net>
	<20190127170820.28937-8-mail@cbaines.net>
From: Ricardo Wurmus <rekado@elephly.net>
In-reply-to: <20190127170820.28937-8-mail@cbaines.net>
Date: Sun, 27 Jan 2019 18:34:06 +0100
Message-ID: <87womqromp.fsf@elephly.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Christopher Baines <mail@cbaines.net>
Cc: 34222@debbugs.gnu.org


Christopher Baines <mail@cbaines.net> writes:

> Required for ruby-ast.
>
> * gnu/packages/ruby.scm (ruby-rest-client): New variable.

[=E2=80=A6]

> +       (modify-phases %standard-phases
> +         (add-before 'check 'fix-dependencies
> +           (lambda _
> +             (substitute* "rest-client.gemspec"
> +               ((".*rubocop.*") "\n")
> +               ((".*pry.*") "\n"))
> +             #t))

Could you please add a comment here why this is necessary?

> +    (description
> +     "@code{rest-client} provides a simple HTTP and REST client for Ruby,
> +inspired by the Sinatra microframework style of specifying actions: get,=
 put,
> +post, delete.")

I would wrap =E2=80=9Cget=E2=80=9D, =E2=80=9Cput=E2=80=9D, =E2=80=9Cpost=E2=
=80=9D, and =E2=80=9Cdelete=E2=80=9D in @code{=E2=80=A6}.

--=20
Ricardo