From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([209.51.188.92]:39485)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hBmXd-0003Dy-4J
	for guix-patches@gnu.org; Wed, 03 Apr 2019 16:31:26 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hBmJs-0005Ar-JL
	for guix-patches@gnu.org; Wed, 03 Apr 2019 16:17:14 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:57948)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1hBmJj-0004xR-2g
	for guix-patches@gnu.org; Wed, 03 Apr 2019 16:17:07 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hBmJi-000070-LY
	for guix-patches@gnu.org; Wed, 03 Apr 2019 16:17:02 -0400
Subject: [bug#35110] [PATCH 1/3] gnu: Add make-linux-module.
Resent-Message-ID: <handler.35110.B35110.1554322582374@debbugs.gnu.org>
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
References: <20190402192729.5262-1-dannym@scratchpost.org>
	<20190402192855.5314-1-dannym@scratchpost.org>
Date: Wed, 03 Apr 2019 22:16:07 +0200
In-Reply-To: <20190402192855.5314-1-dannym@scratchpost.org> (Danny
	Milosavljevic's message of "Tue, 2 Apr 2019 21:28:53 +0200")
Message-ID: <87wokargjc.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Danny Milosavljevic <dannym@scratchpost.org>
Cc: 35110@debbugs.gnu.org

Hi Danny,

Danny Milosavljevic <dannym@scratchpost.org> skribis:

> * gnu/packages/linux.scm (make-linux-module): New procedure.

Neat!

Would it make sense to turn it into a =E2=80=98linux-module-build-system=E2=
=80=99?  That
would avoid having to create a package object that cannot be built, just
to pass it to =E2=80=98make-linux-module=E2=80=99.  =E2=80=98linux-libre=E2=
=80=99 and =E2=80=98kmod=E2=80=99 would be
implicit inputs.

> +;; FIXME: Remove CONFIG_MODULE_SRCVERSION_ALL=3Dy from our configs.

What does that flag do?

> +      (name (string-append (package-name module) "-" (package-name linux=
)))
> +      (native-inputs
> +       `(("linux-source" ,linux-source)
> +         ("kmod" ,kmod)
> +         ;("elfutils" ,elfutils)  ; Needed to enable CONFIG_STACK_VALIDA=
TION
> +         ("gcc" ,gcc-7)

Is it OK to use the default GCC?

Other than that it looks really cool!

Thank you,
Ludo=E2=80=99.