From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([209.51.188.92]:40633)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hO0ad-0002v9-Mc
	for guix-patches@gnu.org; Tue, 07 May 2019 09:57:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hO0ac-0002ZO-NN
	for guix-patches@gnu.org; Tue, 07 May 2019 09:57:03 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:45718)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1hO0ac-0002ZE-Jp
	for guix-patches@gnu.org; Tue, 07 May 2019 09:57:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hO0ac-0008VF-GB
	for guix-patches@gnu.org; Tue, 07 May 2019 09:57:02 -0400
Subject: [bug#35493] [PATCH 1/3] gnu: slim: Allow customisation of Xorg
	display.
Resent-Message-ID: <handler.35493.B35493.155723736432645@debbugs.gnu.org>
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
References: <871s1kad42.fsf@GlaDOS.home> <87zho88yh4.fsf@GlaDOS.home>
	<87muk0m13s.fsf@gnu.org> <874l67rf8o.fsf@GlaDOS.home>
Date: Tue, 07 May 2019 15:55:53 +0200
In-Reply-To: <874l67rf8o.fsf@GlaDOS.home> (Diego Nicola Barbato's message of
	"Mon, 06 May 2019 13:31:35 +0200")
Message-ID: <87woj25pxy.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Diego Nicola Barbato <dnbarbato@posteo.de>
Cc: 35493@debbugs.gnu.org

Hi Diego,

Diego Nicola Barbato <dnbarbato@posteo.de> skribis:

> Ludovic Court=C3=A8s <ludo@gnu.org> writes:

[...]

>> The patch LGTM.  Just one question: did you submit it upstream (is there
>> still an upstream?), and if so, could we add the URL of upstream=E2=80=
=99s
>> tracking software or an indication about the submission?
>
> I did not submit it upstream (the most likely candidate seems to be this
> [0] even though it is not mentioned e.g. on the ArchWiki), since the
> general consensus seems to be that the project has been abandoned.

That makes sense.

I=E2=80=99ve applied the 3 patches and confirmed that
gnu/system/examples/vm-image.tmpl, which uses SLiM, still works
correctly.

However, I=E2=80=99ve noticed that this changes the name of the default She=
pherd
service from =E2=80=98xorg-server=E2=80=99 to =E2=80=98xorg-server-vt7=E2=
=80=99.

What about generating an =E2=80=98xorg-server=E2=80=99 Shepherd service tha=
t would
depend on all the =E2=80=98xorg-server-vtN=E2=80=99 services?  Hmm that wou=
ldn=E2=80=99t be
entirely equivalent: =E2=80=98herd start xorg-server=E2=80=99 would start t=
hem all, but
=E2=80=98herd stop xorg-server=E2=80=99 wouldn=E2=80=99t stop any of them.

Perhaps a simple fix is, when there=E2=80=99s only one server launched, to =
have
the Shepherd service provide both =E2=80=98xorg-server-vtN=E2=80=99 and =E2=
=80=98xorg-server=E2=80=99.
Or to special-case vt7 such that the service for vt7 provides both
=E2=80=98xorg-server=E2=80=99 and =E2=80=98xorg-server-vt7=E2=80=99.

Thoughts?

Thanks,
Ludo=E2=80=99.