* [bug#35999] [PATCH] gnu: add gthumb
@ 2019-05-30 7:02 atai
2019-05-30 7:10 ` atai
0 siblings, 1 reply; 4+ messages in thread
From: atai @ 2019-05-30 7:02 UTC (permalink / raw)
To: 35999; +Cc: Andy Tai
From: Andy Tai <atai@atai.org>
* gnu/packages/gnome.scm (gthumb): Add at 3.8.0
---
gnu/packages/gnome.scm | 40 ++++++++++++++++++++++++++++++++++++++++
1 file changed, 40 insertions(+)
diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index 14e63280ed..e1aa6c6fc5 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -7974,3 +7974,43 @@ functionality.")
(license (list license:lgpl2.1 license:lgpl3 ; either one of these
license:openldap2.8 ; addressbook/gui/component/openldap-extract.h
license:lgpl2.1+)))) ; smime/lib/*
+
+
+(define-public gthumb
+ (package
+ (name "gthumb")
+ (version "3.8.0")
+ (source (origin
+ (method url-fetch)
+ (uri (string-append "mirror://gnome/sources/gthumb/"
+ (version-major+minor version) "/"
+ "gthumb-" version ".tar.xz"))
+ (sha256
+ (base32
+ "1l2s1facq1r6yvqjqc34aqfzlvb3nhkhn79xisxbbdlgrrxdq52f"))))
+ (build-system meson-build-system)
+ (arguments
+ `(#:validate-runpath? #f))
+ (native-inputs
+ `(("pkg-config" ,pkg-config)
+ ("glib:bin" ,glib "bin") ; For glib-compile-resources
+ ("gtk+:bin" ,gtk+ "bin") ; For gtk-update-icon-cache
+ ("desktop-file-utils" ,desktop-file-utils) ; for update-desktop-database
+ ("intltool" ,intltool)
+ ("itstool" ,itstool)))
+ (inputs
+ `(("exiv2" ,exiv2)
+ ("gtk" ,gtk+)
+ ("gsettings-desktop-schemas" ,gsettings-desktop-schemas)
+ ("gstreamer" ,gstreamer)
+ ("clutter" ,clutter)
+ ("clutter-gst" ,clutter-gst)
+ ("clutter-gtk" ,clutter-gtk)
+ ("libjpeg" ,libjpeg)
+ ("libtiff" ,libtiff)
+ ("libraw" ,libraw)))
+ (synopsis "GNOME image viewer and browser")
+ (description "GThumb is an image viewer, browser, organizer, editor and
+advanced image management tool")
+ (home-page "https://wiki.gnome.org/Apps/Ghex")
+ (license license:gpl2+)))
--
2.20.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [bug#35999] [PATCH] gnu: add gthumb
2019-05-30 7:02 [bug#35999] [PATCH] gnu: add gthumb atai
@ 2019-05-30 7:10 ` atai
2019-05-30 7:37 ` Ricardo Wurmus
0 siblings, 1 reply; 4+ messages in thread
From: atai @ 2019-05-30 7:10 UTC (permalink / raw)
To: 35999; +Cc: Andy Tai
From: Andy Tai <atai@atai.org>
* gnu/packages/gnome.scm (gthumb): Add at 3.8.0
---
gnu/packages/gnome.scm | 40 ++++++++++++++++++++++++++++++++++++++++
1 file changed, 40 insertions(+)
diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index 14e63280ed..371d8b2509 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -7974,3 +7974,43 @@ functionality.")
(license (list license:lgpl2.1 license:lgpl3 ; either one of these
license:openldap2.8 ; addressbook/gui/component/openldap-extract.h
license:lgpl2.1+)))) ; smime/lib/*
+
+
+(define-public gthumb
+ (package
+ (name "gthumb")
+ (version "3.8.0")
+ (source (origin
+ (method url-fetch)
+ (uri (string-append "mirror://gnome/sources/gthumb/"
+ (version-major+minor version) "/"
+ "gthumb-" version ".tar.xz"))
+ (sha256
+ (base32
+ "1l2s1facq1r6yvqjqc34aqfzlvb3nhkhn79xisxbbdlgrrxdq52f"))))
+ (build-system meson-build-system)
+ (arguments
+ `(#:validate-runpath? #f))
+ (native-inputs
+ `(("pkg-config" ,pkg-config)
+ ("glib:bin" ,glib "bin") ; For glib-compile-resources
+ ("gtk+:bin" ,gtk+ "bin") ; For gtk-update-icon-cache
+ ("desktop-file-utils" ,desktop-file-utils) ; for update-desktop-database
+ ("intltool" ,intltool)
+ ("itstool" ,itstool)))
+ (inputs
+ `(("exiv2" ,exiv2)
+ ("gtk" ,gtk+)
+ ("gsettings-desktop-schemas" ,gsettings-desktop-schemas)
+ ("gstreamer" ,gstreamer)
+ ("clutter" ,clutter)
+ ("clutter-gst" ,clutter-gst)
+ ("clutter-gtk" ,clutter-gtk)
+ ("libjpeg" ,libjpeg)
+ ("libtiff" ,libtiff)
+ ("libraw" ,libraw)))
+ (synopsis "GNOME image viewer and browser")
+ (description "GThumb is an image viewer, browser, organizer, editor and
+advanced image management tool")
+ (home-page "https://wiki.gnome.org/Apps/Gthumb")
+ (license license:gpl2+)))
--
2.20.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [bug#35999] [PATCH] gnu: add gthumb
2019-05-30 7:10 ` atai
@ 2019-05-30 7:37 ` Ricardo Wurmus
2019-05-30 9:51 ` bug#35999: " Ricardo Wurmus
0 siblings, 1 reply; 4+ messages in thread
From: Ricardo Wurmus @ 2019-05-30 7:37 UTC (permalink / raw)
To: Andy Tai; +Cc: 35999
Hi Andy,
> * gnu/packages/gnome.scm (gthumb): Add at 3.8.0
thanks for the patch.
(Note that the commit message should be “Add variable.”)
> + (arguments
> + `(#:validate-runpath? #f))
It’s not a good idea to disable RUNPATH validation, because it usually
shows you that something might be wrong. In this package the problem is
that the RUNPATH does not include the lib/gthumb/extensions
directory.
I’m still fighting with a handful of binaries that don’t seem to get the
right RUNPATH, but once that’s done I’ll push the updated patch to the
master branch.
--
Ricardo
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#35999: [PATCH] gnu: add gthumb
2019-05-30 7:37 ` Ricardo Wurmus
@ 2019-05-30 9:51 ` Ricardo Wurmus
0 siblings, 0 replies; 4+ messages in thread
From: Ricardo Wurmus @ 2019-05-30 9:51 UTC (permalink / raw)
To: Andy Tai; +Cc: 35999-done
Ricardo Wurmus <rekado@elephly.net> writes:
> Hi Andy,
>
>> * gnu/packages/gnome.scm (gthumb): Add at 3.8.0
>
> thanks for the patch.
>
> (Note that the commit message should be “Add variable.”)
>
>
>> + (arguments
>> + `(#:validate-runpath? #f))
>
> It’s not a good idea to disable RUNPATH validation, because it usually
> shows you that something might be wrong. In this package the problem is
> that the RUNPATH does not include the lib/gthumb/extensions
> directory.
>
> I’m still fighting with a handful of binaries that don’t seem to get the
> right RUNPATH, but once that’s done I’ll push the updated patch to the
> master branch.
Pushed to the master branch with commit 169d63f533.
I fixed the RUNPATH problems and made sure the application doesn’t crash
with a GLib-GIO-ERROR error by adding #:glib-or-gtk? #t.
--
Ricardo
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-05-30 21:40 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-05-30 7:02 [bug#35999] [PATCH] gnu: add gthumb atai
2019-05-30 7:10 ` atai
2019-05-30 7:37 ` Ricardo Wurmus
2019-05-30 9:51 ` bug#35999: " Ricardo Wurmus
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).