From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:50468)
 by lists.gnu.org with esmtp (Exim 4.86_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hjslr-0000l1-04
 for guix-patches@gnu.org; Sat, 06 Jul 2019 18:03:03 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hjslq-000721-0e
 for guix-patches@gnu.org; Sat, 06 Jul 2019 18:03:02 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:47129)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1hjslp-00071u-Sy
 for guix-patches@gnu.org; Sat, 06 Jul 2019 18:03:01 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hjslp-0005vO-Nn
 for guix-patches@gnu.org; Sat, 06 Jul 2019 18:03:01 -0400
Subject: [bug#36404] [PATCH 0/3] Refactor out common behavior for system
 reconfiguration.
Resent-Message-ID: <handler.36404.B36404.156245053722716@debbugs.gnu.org>
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
References: <87o92ianbj.fsf@sdf.lonestar.org> <87o92glap5.fsf@dustycloud.org>
 <878sthoqzi.fsf@gnu.org> <87r2799tzd.fsf@sdf.lonestar.org>
 <87d0isrsmk.fsf@sdf.lonestar.org> <878std3fw0.fsf@sdf.lonestar.org>
 <87wogwoqrg.fsf@gnu.org> <87bly8f3kq.fsf_-_@sdf.lonestar.org>
Date: Sun, 07 Jul 2019 00:02:01 +0200
In-Reply-To: <87bly8f3kq.fsf_-_@sdf.lonestar.org> (Jakob L. Kreuze's message
 of "Fri, 05 Jul 2019 19:45:41 -0400")
Message-ID: <87wogug6ue.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: "Jakob L. Kreuze" <zerodaysfordays@sdf.lonestar.org>
Cc: 36404@debbugs.gnu.org

Hello,

zerodaysfordays@sdf.lonestar.org (Jakob L. Kreuze) skribis:

> Ludovic Court=C3=A8s <ludo@gnu.org> writes:
>
>> Note that writing tests could be tricky because it=E2=80=99s about testi=
ng the
>> effect of these reconfigure actions.  At any rate, let us know how it
>> goes!
>
> This is a _very_ preliminary patch series. I'm not nearly done with it
> yet; the procedures in guix/scripts/system.scm that I've replaced have
> some handling for i.e. installing the bootloader configuration without
> running the installer script, which my reimplementations don't yet
> support.
>
> I'm sending this tonight to make sure I'm on the right track: is this
> sort of what you meant by extracting the common behavior into scripts?

Yes!

> Also, I didn't include any tests as part of this series, but
> implementing reconfiguration like this does, indeed, make testing for
> 'guix deploy' much, much easier. And we'll get some tests for the
> behavior of 'guix system reconfigure' out of it, too!

As you can imagine we=E2=80=99ll have to be careful with =E2=80=98guix syst=
em
reconfigure=E2=80=99=E2=80=94let=E2=80=99s not break everyone=E2=80=99s sys=
tem.  ;-)

But yes, it seems like the right thing to me.

Ludo=E2=80=99.