From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:48376)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1i5UT9-0002Sq-7v
 for guix-patches@gnu.org; Wed, 04 Sep 2019 08:33:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1i5UT8-00067C-8B
 for guix-patches@gnu.org; Wed, 04 Sep 2019 08:33:03 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:52151)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1i5UT8-000673-4q
 for guix-patches@gnu.org; Wed, 04 Sep 2019 08:33:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1i5UT7-0004qS-Uq
 for guix-patches@gnu.org; Wed, 04 Sep 2019 08:33:02 -0400
Subject: [bug#36477] [PATCH v3 43/48] utils: Use target-arm64? and target-arm?
 helpers.
Resent-Message-ID: <handler.36477.B36477.156760036118599@debbugs.gnu.org>
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
References: <20190902153333.11190-1-m.othacehe@gmail.com>
 <20190902153333.11190-44-m.othacehe@gmail.com>
Date: Wed, 04 Sep 2019 14:32:32 +0200
In-Reply-To: <20190902153333.11190-44-m.othacehe@gmail.com> (Mathieu
 Othacehe's message of "Mon, 2 Sep 2019 17:33:28 +0200")
Message-ID: <87woeo44yn.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Mathieu Othacehe <m.othacehe@gmail.com>
Cc: 36477@debbugs.gnu.org

Mathieu Othacehe <m.othacehe@gmail.com> skribis:

> * guix/utils.scm (target-arm64?, target-arm?): New exported procedures.
> ---
>  guix/utils.scm | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/guix/utils.scm b/guix/utils.scm
> index f480c3291f..3eb156ad4e 100644
> --- a/guix/utils.scm
> +++ b/guix/utils.scm
> @@ -78,6 +78,8 @@
>              package-name->name+version
>              target-mingw?
>              target-arm32?
> +            target-arm64?
> +            target-arm?
>              target-64bit?
>              version-compare
>              version>?
> @@ -493,6 +495,12 @@ a character other than '@'."
>  (define (target-arm32?)
>    (string-prefix? "arm" (or (%current-target-system) (%current-system))))
>=20=20
> +(define (target-arm64?)
> +  (string-prefix? "aarch64" (or (%current-target-system) (%current-syste=
m))))

I=E2=80=99d call it =E2=80=98target-aarch64?=E2=80=99 because that=E2=80=99=
s what it=E2=80=99s called upstream,
and that=E2=80=99s also the name we use elsewhere in Guix.  WDYT?

Apart from that LGTM!

Ludo=E2=80=99.