From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:39989)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ifVrT-0001XD-24
 for guix-patches@gnu.org; Thu, 12 Dec 2019 16:19:04 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ifVrR-0008Ba-Vs
 for guix-patches@gnu.org; Thu, 12 Dec 2019 16:19:02 -0500
Received: from debbugs.gnu.org ([209.51.188.43]:54993)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1ifVrR-0008BA-RQ
 for guix-patches@gnu.org; Thu, 12 Dec 2019 16:19:01 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ifVrR-0004c3-NI
 for guix-patches@gnu.org; Thu, 12 Dec 2019 16:19:01 -0500
Subject: [bug#37730] [PATCH] Topologically sort recursively-imported packages
Resent-Message-ID: <handler.37730.D37730.157618550717690@debbugs.gnu.org>
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
References: <CAAc=MEycXPYeT_ZhkyQNO7Gusjj7tNixdAr7mVQgoS82ruoZrQ@mail.gmail.com>
 <87lfti5rip.fsf@gnu.org>
 <CAAc=MEyzhSWtmLwrfXmz1tr3_R74xenERX53gRuP4hOiiGXX8g@mail.gmail.com>
 <CAAc=MEwpYfW5OdgNv6Xm-db2LoKo=hnEE+70Q5DHu+23K19WMw@mail.gmail.com>
 <87immqpww5.fsf@gnu.org>
 <CAAc=MEwYSqMqdOE62YeH248DrvyE9vk0t3U8wOagdq-hY+cK9w@mail.gmail.com>
 <87pngvje7f.fsf@gnu.org> <87sglp379m.fsf@elephly.net>
Date: Thu, 12 Dec 2019 22:18:17 +0100
In-Reply-To: <87sglp379m.fsf@elephly.net> (Ricardo Wurmus's message of "Thu,
 12 Dec 2019 16:15:01 +0100")
Message-ID: <87wob1450m.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Ricardo Wurmus <rekado@elephly.net>
Cc: Brian Leung <bkleung89@gmail.com>, 37730-done@debbugs.gnu.org

Hi,

Ricardo Wurmus <rekado@elephly.net> skribis:

> Ludovic Court=C3=A8s <ludo@gnu.org> writes:
>
>> Hi Brian,
>>
>> Brian Leung <bkleung89@gmail.com> skribis:
>>
>>>> If that=E2=80=99s fine with you, I=E2=80=99d be willing to apply this =
patch, and then
>>>> apply other bits of your patch (the tests and stream removal) on top of
>>>> it.  How does that sound?
>>>
>>> Sure, your patch seems clearer to me.
>>
>> I pushed patches that combine mine and yours:
>>
>>   4982de4c32 import: crate: Add recursive import test.
>>   70a8e13277 import: utils: 'recursive-import' returns a list rather tha=
n a stream.
>>   ddd5915900 import: utils: 'recursive-import' returns packages in topol=
ogical order.
>
> Thank you!
>
>> Let me know if you notice anything wrong!
>
> I believe the docstring of RECURSIVE-IMPORT in (guix import utils) needs
> to be adjusted.  It still refers to streams.

Oops, fixed!  (Will push shortly.)

Thanks,
Ludo=E2=80=99.