From: Tobias Geerinckx-Rice via Guix-patches via <guix-patches@gnu.org>
To: 38799-done@debbugs.gnu.org, "Jakub Kądziołka" <kuba@kadziolka.net>
Subject: bug#38799: [PATCH v2] gnu: vim: Update to 8.2.0066.
Date: Tue, 31 Dec 2019 23:49:23 +0100 [thread overview]
Message-ID: <87woacun4c.fsf@nckx> (raw)
In-Reply-To: <20191231202134.o7npk5xcw3w46fw5@zdrowyportier.kadziolka.net>
[-- Attachment #1: Type: text/plain, Size: 941 bytes --]
Jakub,
Jakub Kądziołka 写道：
> Vim pushed some new commits that look desirable -- 8.2.0063
> seems to
> have fixed a crash -- so here's a new patch with a bumped
> version &
> hash.
Thank you! I've made only tiny cosmetic changes:
- Added a copyright line for you as discussed on IRC.
- I agree with your source indentation fixes, but they make this
patch less clear. Let's keep them for when we ever switch to
URL-FETCH, for example.
- Shortened the MegaComment — it was very clear (thank you!) but
longer than is customary.
- The awkward indentation of the tzdata-for-tests comment bothered
me. I replaced it with a less detailed but, again, customary
variant. It's not like something will be silently missing if
anyone tries removing it: the test suite will fail, loudly.
Linted and pushed as 9efcc4948143a845355f7869fe05dbcca0f74a34.
Happy 2020!
Kind regards,
T G-R
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
prev parent reply other threads:[~2019-12-31 22:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-29 17:34 [bug#38799] [PATCH] gnu: vim: Update to 8.2.0055 Jakub Kądziołka
2019-12-30 0:33 ` Tobias Geerinckx-Rice via Guix-patches via
2019-12-31 20:21 ` [bug#38799] [PATCH v2] gnu: vim: Update to 8.2.0066 Jakub Kądziołka
2019-12-31 22:49 ` Tobias Geerinckx-Rice via Guix-patches via [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87woacun4c.fsf@nckx \
--to=guix-patches@gnu.org \
--cc=38799-done@debbugs.gnu.org \
--cc=kuba@kadziolka.net \
--cc=me@tobias.gr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).