From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:36102) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j3hWB-0002fE-Gk for guix-patches@gnu.org; Mon, 17 Feb 2020 09:37:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j3hWA-00016s-D6 for guix-patches@gnu.org; Mon, 17 Feb 2020 09:37:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:60458) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j3hWA-00016m-9n for guix-patches@gnu.org; Mon, 17 Feb 2020 09:37:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1j3hWA-0003iz-7j for guix-patches@gnu.org; Mon, 17 Feb 2020 09:37:02 -0500 Subject: [bug#38408] [PATCH v9 3/8] Added Guile-Semver as a dependency to guix Resent-Message-ID: From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <8a86631d201313b1da427a5ceb2ca5f201e6546c.1580817140.git.mjbecze@riseup.net> <20200217100345.GI1968@E5400> Date: Mon, 17 Feb 2020 15:36:05 +0100 In-Reply-To: <20200217100345.GI1968@E5400> (Efraim Flashner's message of "Mon, 17 Feb 2020 12:03:45 +0200") Message-ID: <87wo8l702y.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Efraim Flashner Cc: 38408@debbugs.gnu.org, jsoo1@asu.edu, Martin Becze Hi, Efraim Flashner skribis: > From 578d6f023c706df999c1b1b1bb23c9771b279857 Mon Sep 17 00:00:00 2001 > From: Martin Becze > Date: Tue, 4 Feb 2020 07:18:20 -0500 > Subject: [PATCH 3/8] Added Guile-Semver as a dependency to guix > > * configure.ac: added check for guile-semver > * gnu/packages/package-management.scm (guix): added guile-semver as dep [...] > +dnl Check for Guile-Semver > +GUILE_MODULE_AVAILABLE([have_guile_semver], [(semver)]) > +if test "x$have_guile_semver" !=3D "xyes"; then > + AC_MSG_ERROR([Guile-Semver is missing; please install it.]) > +fi I think a hard dependency like this is too much. I would very much prefer to deal with it similar to how we deal with Guile-Newt or Guile-Charting: a soft dependency that=E2=80=99s entirely optional. But I guess that also depends on what Guile-Semver is used for. I just posted a question on this topic in that thread. :-) Thanks for reviving this patch series! Ludo=E2=80=99.