From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Masaya Tojo <masaya@tojo.tokyo>
Cc: 39818@debbugs.gnu.org
Subject: [bug#39818] [PATCH] gnu: Add emacs-ddskk.
Date: Sat, 29 Feb 2020 20:35:34 +0100 [thread overview]
Message-ID: <87wo852nll.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <RBSjADghVPemvtNv7mi9eAoMggKAs5j95fTjdEDP5xhK6NqrkrQV-6rpW9xWP-_dFZvsXwx86wqMI--1LDn6Akv1vo3cyv1ZbiFfGnePKY8=@tojo.tokyo> (Masaya Tojo's message of "Fri, 28 Feb 2020 00:44:22 +0000")
Hello,
Masaya Tojo <masaya@tojo.tokyo> writes:
> * gnu/packages/emacs-xyz.scm (emacs-ddskk): New variable.
Thank you!
> +(define emacs-ddskk
Wouldn't it be emacs-skk, since one need to (require 'skk)?
> + (package
> + (name "emacs-ddskk")
> + (version "17.0.50")
Is it an unstable version? Latest release seems to be 16.3. If so, if
there is a strong reason to use it instead, we should give it in
a comment.
> + (home-page "https://github.com/skk-dev/ddskk")
This should be at the end of the package definition, right above
`synopsis'.
> + (source
> + (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url home-page)
> + (commit "b7bf6fa0e0fbb562c27a887283627a8781de0a34")))
> + (file-name (git-file-name name version))
> + (sha256
> + (base32
> + "1ysn73yysaxpm93y9d4g2hmnd7qhh6lv93wgkrdw1cx11xl1g7yk"))))
> + (build-system emacs-build-system)
> + (inputs `(("inetutils" ,inetutils)))
> + (synopsis "Simple Kana to Kanji conversion program")
> + (description "Daredevil SKK is a version of SKK (Simple Kana to Kanji
> + conversion program, an input method of Japanese)
is a version of @acronym{SKK, Simple Kana to Kanji} conversion program,
an input method of Japanese.
> + maintained by the SKK development team at http://openlab.jp/skk.")
We may want to drop that part, not very useful in the package
description. However, if you keep it, it should be
@url{http://openlab.jp/skk}.
BTW, I cannot apply your patch. Could you send an updated revision with
the changes suggested above?
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2020-02-29 19:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-28 0:44 [bug#39818] [PATCH] gnu: Add emacs-ddskk Masaya Tojo
2020-02-29 19:35 ` Nicolas Goaziou [this message]
[not found] ` <mail.5e5d995c.1c97.70ed96d75f632e87@storage.wm.amazon.com>
[not found] ` <010001709d9f1515-a80e6286-86e1-4d06-84e8-038105e92a9d-000000@email.amazonses.com>
2020-03-03 8:05 ` Nicolas Goaziou
[not found] ` <20200305231315.05b00017@tojo.tokyo>
[not found] ` <01000170ab0b4eb9-d3e8120a-d15a-480e-80b7-f5de68f7301d-000000@email.amazonses.com>
2020-03-05 18:26 ` bug#39818: " Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wo852nll.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=39818@debbugs.gnu.org \
--cc=masaya@tojo.tokyo \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).