From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:54253) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jC6f9-00012A-Fo for guix-patches@gnu.org; Wed, 11 Mar 2020 15:05:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jC6f8-0007Gd-6p for guix-patches@gnu.org; Wed, 11 Mar 2020 15:05:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:49554) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jC6f7-0007GW-Uw for guix-patches@gnu.org; Wed, 11 Mar 2020 15:05:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jC6f7-0007Md-QZ for guix-patches@gnu.org; Wed, 11 Mar 2020 15:05:01 -0400 Subject: [bug#40025] [PATCH] Add gitless package definition. References: <20200311151137.32198-1-jboy@bius.moe> In-Reply-To: <20200311151137.32198-1-jboy@bius.moe> Resent-Message-ID: Date: Wed, 11 Mar 2020 20:05:27 +0100 Message-ID: <87wo7qhfuw.fsf@nckx> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" Reply-to: Tobias Geerinckx-Rice , Tobias Geerinckx-Rice via Guix-patches From: Tobias Geerinckx-Rice via Guix-patches via To: 40025@debbugs.gnu.org --=-=-= Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable John, Thanks for the patch! Guix uses a specific commit message format. It's partially=20 documented in =E2=80=98(guix)Submitting Patches=E2=80=99 but you're IMO bet= ter off=20 just reading the git history to get a feel for it. Here's the=20 commit message for this package: gnu: Add gitless. * gnu/packages/version-control.scm (gitless): New public=20 variable. Co-authored-by: Tobias Geerinckx-Rice I've written down my comments below, but you don't need to send a=20 V2. I'll try to make it work here and will push a modified version if=20 I succeed. It would be nice if I could get rid of propagation,=20 and the path to a (non-native) git still needs to be embedded so=20 the user doesn't need to install git themselves. > + (uri (git-reference > + (url "https://github.com/gitless-vcs/gitless") > + (commit (string-append "v" version)))) This is missing the FILE-NAME field. Without it, the source is=20 checked out into /gnu/store/-checkout/ which makes it harder=20 to see what's what. Adding (file-name (git-file-name name version)) puts it in=20 /gnu/store/-gitless--checkout. > + (substitute* "requirements.txt" > + (("pygit2=3D=3D") "pygit2>=3D")) This has no effect on the end result so I suggest we drop it=20 again. > + (synopsis > + "A version control system built on top of Git") Synopses shouldn't start with an article. Tip: running =E2=80=98./pre-inst-env guix lint gitless=E2=80=99 will catch = things=20 like this. It also caught the missing FILE-NAME. It also printed several warnings about using tabs instead of=20 spaces. Guix does not use tabs in Scheme code. > + (description > + "A version control system built on top of Git") This is waaay too short, I told you that before :-p Moreover,=20 descriptions should consist of complete sentences. I've knocked=20 something together based on the home page blurb: Gitless is a Git-compatible version control system that aims to=20 be easy to learn and use. It simplifies the common workflow by committing changes to tracked files by default and saving any uncommitted changes as part of a branch. The friendly @command{gl} command-line interface gives feedback=20 and helps you figure out what to do next. Gitless is implemented on top of Git and its commits and=20 repositories are indistinguishable from Git's. You (or other contributors)=20 can always fall back on @command{git}, and use any regular Git=20 hosting service. Kind regards, T G-R --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEfo+u0AlEeO9y5k0W2Imw8BjFSTwFAl5pNncACgkQ2Imw8BjF STwnZxAAnyk4VTO2C6FgbErtYghtq1fQ5WUsjxfUMofYv9IjF4TFf1hQiI6Ssb5Y TvbpPIC+6d+cht0sI1X8eWZZ1TH/fkyfNoczUI52nzgAR6IQZAqNRKOhtWZhjPGN lXe0bnqE+x3Mba/Nus0g+jUi9BDzZ7w0e95mKHytxgCPSsfqRJ+Uh13TI/SMlkWM SbtrJhaHkR0OfwrvhyQLyIZVu88doUrB1tvZfSftnJ1IZy2WEsSnVJK2Mx+aTPMR 2WOH/8hcURJeeEccHWAWbB0NQMHslohk+tZmmZ4Pw89vboGfy9+pgDOL+E6vaRkD WS/8Bom9uVtc2TuLBPDBblRXP4o3mMBXBWolNr96T85G5kDDseI/OA8XtuAPY4BW mFrjjyJ2nGQAEN/ItVQkBX/F0Y84WqLc5lZhNkvnw3gvJADKHxOgJBHc3goXgp1p WIelWgSmqVcesBR9D3EAwzTb+89VDaRavmPFM4Ri7KCH2qOqI3+qqmgCV5R6VKoO TpNwakp3pxGJy6d608xTL7PmiZIZTJyAqgCT73m4Rmvct0kIAOwRSiDECKp8cwOy ZZ8aAFKGJL0OcQ8TCd4HL8OTjUtnhaUQhJ4+03i/4hw3Z11nzai6uQUS8E4Iq/SI PUO2wve0PF4j8lGngBnTnZW03eIiRn/S2VQx7yz1+PWdxfmPx7o= =mSi5 -----END PGP SIGNATURE----- --=-=-=--